Skip to content

Commit

Permalink
MDL-27555 assignment module: remove 'submitted' option from optional …
Browse files Browse the repository at this point in the history 
…setting for offline assignment type.
  • Loading branch information
Rossiani Wijaya committed Jul 5, 2011
1 parent 81f8e0f commit 54c37fb
Showing 1 changed file with 60 additions and 31 deletions.
91 changes: 60 additions & 31 deletions mod/assignment/lib.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,10 @@ function submittedlink($allgroups=false) {
} else {
$group = groups_get_activity_group($this->cm);
}
if ($count = $this->count_real_submissions($group)) {
if ($this->type == 'offline') {
$submitted = '<a href="'.$urlbase.'submissions.php?id='.$this->cm->id.'">'.
get_string('viewfeedback', 'assignment').'</a>';
} else if ($count = $this->count_real_submissions($group)) {
$submitted = '<a href="'.$urlbase.'submissions.php?id='.$this->cm->id.'">'.
get_string('viewsubmissions', 'assignment', $count).'</a>';
} else {
Expand Down Expand Up @@ -945,6 +948,10 @@ function display_submission($offset=-1,$userid =-1, $display=true) {
$cm = $this->cm;
$context = get_context_instance(CONTEXT_MODULE, $cm->id);

//reset filter to all for offline assignment
if ($assignment->assignmenttype == 'offline' && $filter == self::FILTER_SUBMITTED) {
$filter = self::FILTER_ALL;
}
/// Get all ppl that can submit assignments

$currentgroup = groups_get_activity_group($cm);
Expand All @@ -961,9 +968,9 @@ function display_submission($offset=-1,$userid =-1, $display=true) {

$nextid = 0;
$where = '';
if($filter == 'submitted') {
if($filter == self::FILTER_SUBMITTED) {
$where .= 's.timemodified > 0 AND ';
} else if($filter == 'requiregrading') {
} else if($filter == self::FILTER_REQUIRE_GRADING) {
$where .= 's.timemarked < s.timemodified AND ';
}

Expand Down Expand Up @@ -1092,12 +1099,10 @@ function display_submissions($message='') {
*/

$filters = array(self::FILTER_ALL => get_string('all'),
self::FILTER_SUBMITTED => get_string('submitted', 'assignment'),
self::FILTER_REQUIRE_GRADING => get_string('requiregrading', 'assignment'));

$updatepref = optional_param('updatepref', 0, PARAM_INT);

if (isset($_POST['updatepref'])){
$updatepref = optional_param('updatepref', 0, PARAM_BOOL);
if ($updatepref) {
$perpage = optional_param('perpage', 10, PARAM_INT);
$perpage = ($perpage <= 0) ? 10 : $perpage ;
$filter = optional_param('filter', 0, PARAM_INT);
Expand Down Expand Up @@ -1130,6 +1135,15 @@ function display_submissions($message='') {
$cm = $this->cm;
$hassubmission = false;

// reset filter to all for offline assignment only.
if ($assignment->assignmenttype == 'offline') {
if ($filter == self::FILTER_SUBMITTED) {
$filter = self::FILTER_ALL;
}
} else {
$filters[self::FILTER_SUBMITTED] = get_string('submitted', 'assignment');
}

$tabindex = 1; //tabindex for quick grading tabbing; Not working for dropdowns yet
add_to_log($course->id, 'assignment', 'view submission', 'submissions.php?id='.$this->cm->id, $this->assignment->id, $this->cm->id);

Expand Down Expand Up @@ -1183,23 +1197,34 @@ function display_submissions($message='') {
"LEFT JOIN ($esql) eu ON eu.id=u.id ".
"WHERE u.deleted = 0 AND eu.id=u.id ";
} else {
$wherefilter = '';
$wherefilter = ' AND s.assignment = '. $this->assignment->id;
$assignmentsubmission = "LEFT JOIN {assignment_submissions} s ON (u.id = s.userid) ";
if($filter == self::FILTER_SUBMITTED) {
$wherefilter = ' AND s.timemodified > 0';
} else if($filter == self::FILTER_REQUIRE_GRADING) {
$wherefilter = ' AND s.timemarked < s.timemodified ';
$wherefilter .= ' AND s.timemodified > 0 ';
} else if($filter == self::FILTER_REQUIRE_GRADING && $assignment->assignmenttype != 'offline') {
$wherefilter .= ' AND s.timemarked < s.timemodified ';
} else { // require grading for offline assignment
$assignmentsubmission = "";
$wherefilter = "";
}

$sql = "SELECT u.id FROM {user} u ".
"LEFT JOIN ($esql) eu ON eu.id=u.id ".
"LEFT JOIN {assignment_submissions} s ON (u.id = s.userid) " .
$assignmentsubmission.
"WHERE u.deleted = 0 AND eu.id=u.id ".
'AND s.assignment = '. $this->assignment->id .
$wherefilter;
$wherefilter;
}

$users = $DB->get_records_sql($sql, $params);
if (!empty($users)) {
if($assignment->assignmenttype == 'offline' && $filter == self::FILTER_REQUIRE_GRADING) {
//remove users who has submitted their assignment
foreach ($this->get_submissions() as $submission) {
if (array_key_exists($submission->userid, $users)) {
unset($users[$submission->userid]);
}
}
}
$users = array_keys($users);
}

Expand Down Expand Up @@ -1257,15 +1282,14 @@ function display_submissions($message='') {
$table->set_attribute('id', 'attempts');
$table->set_attribute('class', 'submissions');
$table->set_attribute('width', '100%');
//$table->set_attribute('align', 'center');

$table->no_sorting('finalgrade');
$table->no_sorting('outcome');

// Start working -- this is necessary as soon as the niceties are over
$table->setup();

/// Construct the SQL
/// Construct the SQL
list($where, $params) = $table->get_sql_where();
if ($where) {
$where .= ' AND ';
Expand All @@ -1274,7 +1298,10 @@ function display_submissions($message='') {
if ($filter == self::FILTER_SUBMITTED) {
$where .= 's.timemodified > 0 AND ';
} else if($filter == self::FILTER_REQUIRE_GRADING) {
$where .= 's.timemarked < s.timemodified AND ';
$where = '';
if ($assignment->assignmenttype != 'offline') {
$where .= 's.timemarked < s.timemodified AND ';
}
}

if ($sort = $table->get_sql_sort()) {
Expand Down Expand Up @@ -1450,18 +1477,18 @@ function display_submissions($message='') {
}
$currentposition++;
}
}
if ($hassubmission && ($this->assignment->assignmenttype=='upload' || $this->assignment->assignmenttype=='online' || $this->assignment->assignmenttype=='uploadsingle')) { //TODO: this is an ugly hack, where is the plugin spirit? (skodak)
echo html_writer::start_tag('div', array('class' => 'mod-assignment-download-link'));
echo html_writer::link(new moodle_url('/mod/assignment/submissions.php', array('id' => $this->cm->id, 'download' => 'zip')), get_string('downloadall', 'assignment'));
echo html_writer::end_tag('div');
}
$table->print_html(); /// Print the whole table
} else {
if ($filter == self::FILTER_SUBMITTED) {
echo html_writer::tag('div', get_string('nosubmisson', 'assignment'), array('class'=>'nosubmisson'));
} else if ($filter == self::FILTER_REQUIRE_GRADING) {
echo html_writer::tag('div', get_string('norequiregrading', 'assignment'), array('class'=>'norequiregrading'));
if ($hassubmission && ($this->assignment->assignmenttype=='upload' || $this->assignment->assignmenttype=='online' || $this->assignment->assignmenttype=='uploadsingle')) { //TODO: this is an ugly hack, where is the plugin spirit? (skodak)
echo html_writer::start_tag('div', array('class' => 'mod-assignment-download-link'));
echo html_writer::link(new moodle_url('/mod/assignment/submissions.php', array('id' => $this->cm->id, 'download' => 'zip')), get_string('downloadall', 'assignment'));
echo html_writer::end_tag('div');
}
$table->print_html(); /// Print the whole table
} else {
if ($filter == self::FILTER_SUBMITTED) {
echo html_writer::tag('div', get_string('nosubmisson', 'assignment'), array('class'=>'nosubmisson'));
} else if ($filter == self::FILTER_REQUIRE_GRADING) {
echo html_writer::tag('div', get_string('norequiregrading', 'assignment'), array('class'=>'norequiregrading'));
}
}
}

Expand Down Expand Up @@ -1754,7 +1781,7 @@ function email_teachers($submission) {
$eventdata->notification = 1;
$eventdata->contexturl = $info->url;
$eventdata->contexturlname = $info->assignment;

message_send($eventdata);
}
}
Expand Down Expand Up @@ -3671,7 +3698,9 @@ function assignment_extend_settings_navigation(settings_navigation $settings, na
$group = groups_get_activity_group($PAGE->cm);
}
$link = new moodle_url('/mod/assignment/submissions.php', array('id'=>$PAGE->cm->id));
if ($count = $assignmentinstance->count_real_submissions($group)) {
if ($assignmentrow->assignmenttype == 'offline') {
$string = get_string('viewfeedback', 'assignment');
} else if ($count = $assignmentinstance->count_real_submissions($group)) {
$string = get_string('viewsubmissions', 'assignment', $count);
} else {
$string = get_string('noattempts', 'assignment');
Expand Down

0 comments on commit 54c37fb

Please sign in to comment.