Fail fast when cache_fetch_timeout is unsupported type

dschaller · Oct 25, 2017 · 35e1ffc · 35e1ffc
1 parent 4da4517
commit 35e1ffc
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/tldextract/tldextract.py b/tldextract/tldextract.py
@@ -219,15 +219,8 @@ def __init__(self, cache_file=CACHE_FILE, suffix_list_urls=PUBLIC_SUFFIX_LIST_UR
         self._extractor = None
 
         self.cache_fetch_timeout = cache_fetch_timeout
-        if not isinstance(self.cache_fetch_timeout, (tuple, float,)):
-            try:
-                self.cache_fetch_timeout = float(self.cache_fetch_timeout)
-            except (ValueError, TypeError):
-                LOG.error(
-                    'invalid cache timeout specified (%s). Defaulting to None',
-                    self.cache_fetch_timeout,
-                    exc_info=True
-                )
+        if isinstance(self.cache_fetch_timeout, STRING_TYPE):
+            self.cache_fetch_timeout = float(self.cache_fetch_timeout)
 
     def __call__(self, url):
         """