Skip to content

Commit

Permalink
Ensure Http2FrameCodec uses Http2Settings.defaultSettings()
Browse files Browse the repository at this point in the history
Motivation:

Http2FrameCodec should use Http2Settings.defaultSettings() when no Http2Settings were specified by the user.

Modifications:

Replace new Http2Settings() with Http2Settings.defaultSettings()

Result:

Use correct Http2Settings by default when using Http2FrameCodec in all cases.
  • Loading branch information
normanmaurer committed Aug 1, 2017
1 parent 068e64d commit 2988fb8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public Http2FrameCodec(boolean server) {
* @param server {@code true} this is a server
*/
public Http2FrameCodec(boolean server, Http2FrameLogger frameLogger) {
this(server, new DefaultHttp2FrameWriter(), frameLogger, new Http2Settings());
this(server, new DefaultHttp2FrameWriter(), frameLogger, Http2Settings.defaultSettings());
}

// Visible for testing
Expand Down

0 comments on commit 2988fb8

Please sign in to comment.