Remove usages of deprecated methods group() and childGroup().

Motivation:

These methods were recently deprecated. However, they remained in use in several locations in Netty's codebase.

Modifications:

Netty's code will now access the bootstrap config to get the group or child group.

Result:

No impact on functionality.

codec-http/src/test/java/io/netty/handler/codec/http/HttpClientCodecTest.java

@@ -226,9 +226,9 @@ protected void channelRead0(ChannelHandlerContext ctx, FullHttpResponse msg) {
             clientChannel.writeAndFlush(new DefaultHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET, "/"));
             assertTrue(responseRecievedLatch.await(5, SECONDS));
         } finally {
-            sb.group().shutdownGracefully();
-            sb.childGroup().shutdownGracefully();
-            cb.group().shutdownGracefully();
+            sb.config().group().shutdownGracefully();
+            sb.config().childGroup().shutdownGracefully();
+            cb.config().group().shutdownGracefully();
         }
     }
 }

codec-http2/src/test/java/io/netty/handler/codec/http2/DataCompressionHttp2Test.java

@@ -126,9 +126,9 @@ public void teardown() throws InterruptedException {
             serverChannel.close().sync();
             serverChannel = null;
         }
-        Future<?> serverGroup = sb.group().shutdownGracefully(0, 0, MILLISECONDS);
-        Future<?> serverChildGroup = sb.childGroup().shutdownGracefully(0, 0, MILLISECONDS);
-        Future<?> clientGroup = cb.group().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> serverGroup = sb.config().group().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> serverChildGroup = sb.config().childGroup().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> clientGroup = cb.config().group().shutdownGracefully(0, 0, MILLISECONDS);
         serverGroup.sync();
         serverChildGroup.sync();
         clientGroup.sync();

codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java

@@ -113,9 +113,9 @@ public void teardown() throws Exception {
             serverChannel.close().sync();
             serverChannel = null;
         }
-        Future<?> serverGroup = sb.group().shutdownGracefully(0, 0, MILLISECONDS);
-        Future<?> serverChildGroup = sb.childGroup().shutdownGracefully(0, 0, MILLISECONDS);
-        Future<?> clientGroup = cb.group().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> serverGroup = sb.config().group().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> serverChildGroup = sb.config().childGroup().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> clientGroup = cb.config().group().shutdownGracefully(0, 0, MILLISECONDS);
         serverGroup.sync();
         serverChildGroup.sync();
         clientGroup.sync();

codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java

@@ -110,9 +110,9 @@ public void teardown() throws Exception {
             serverChannel.close().sync();
             serverChannel = null;
         }
-        Future<?> serverGroup = sb.group().shutdownGracefully(0, 0, MILLISECONDS);
-        Future<?> serverChildGroup = sb.childGroup().shutdownGracefully(0, 0, MILLISECONDS);
-        Future<?> clientGroup = cb.group().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> serverGroup = sb.config().group().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> serverChildGroup = sb.config().childGroup().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> clientGroup = cb.config().group().shutdownGracefully(0, 0, MILLISECONDS);
         serverGroup.sync();
         serverChildGroup.sync();
         clientGroup.sync();

codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java

@@ -118,9 +118,9 @@ public void teardown() throws Exception {
             serverChannel.close().sync();
             serverChannel = null;
         }
-        Future<?> serverGroup = sb.group().shutdownGracefully(0, 0, MILLISECONDS);
-        Future<?> serverChildGroup = sb.childGroup().shutdownGracefully(0, 0, MILLISECONDS);
-        Future<?> clientGroup = cb.group().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> serverGroup = sb.config().group().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> serverChildGroup = sb.config().childGroup().shutdownGracefully(0, 0, MILLISECONDS);
+        Future<?> clientGroup = cb.config().group().shutdownGracefully(0, 0, MILLISECONDS);
         serverGroup.sync();
         serverChildGroup.sync();
         clientGroup.sync();

handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java

@@ -111,9 +111,9 @@ public void setup() {
     public void tearDown() throws InterruptedException {
         if (serverChannel != null) {
             serverChannel.close().sync();
-            Future<?> serverGroup = sb.group().shutdownGracefully(0, 0, TimeUnit.MILLISECONDS);
-            Future<?> serverChildGroup = sb.childGroup().shutdownGracefully(0, 0, TimeUnit.MILLISECONDS);
-            Future<?> clientGroup = cb.group().shutdownGracefully(0, 0, TimeUnit.MILLISECONDS);
+            Future<?> serverGroup = sb.config().group().shutdownGracefully(0, 0, TimeUnit.MILLISECONDS);
+            Future<?> serverChildGroup = sb.config().childGroup().shutdownGracefully(0, 0, TimeUnit.MILLISECONDS);
+            Future<?> clientGroup = cb.config().group().shutdownGracefully(0, 0, TimeUnit.MILLISECONDS);
             serverGroup.sync();
             serverChildGroup.sync();
             clientGroup.sync();

transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java

@@ -327,7 +327,7 @@ final ChannelFuture initAndRegister() {
             return new DefaultChannelPromise(channel, GlobalEventExecutor.INSTANCE).setFailure(t);
         }
 
-        ChannelFuture regFuture = group().register(channel);
+        ChannelFuture regFuture = config().group().register(channel);
         if (regFuture.cause() != null) {
             if (channel.isRegistered()) {
                 channel.close();

transport/src/main/java/io/netty/bootstrap/ServerBootstrap.java

@@ -188,7 +188,7 @@ public ServerBootstrap validate() {
         }
         if (childGroup == null) {
             logger.warn("childGroup is not set. Using parentGroup instead.");
-            childGroup = group();
+            childGroup = config.group();
         }
         return this;
     }

transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java

@@ -187,7 +187,7 @@ public void onTimeout(AcquireTask task) {
                 throw new Error();
             }
         }
-        executor = bootstrap.group().next();
+        executor = bootstrap.config().group().next();
         this.maxConnections = maxConnections;
         this.maxPendingAcquires = maxPendingAcquires;
     }

transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java

@@ -103,7 +103,7 @@ protected void initChannel(Channel ch) throws Exception {
 
     @Override
     public final Future<Channel> acquire() {
-        return acquire(bootstrap.group().next().<Channel>newPromise());
+        return acquire(bootstrap.config().group().next().<Channel>newPromise());
     }
 
     @Override