[Java] Fix endianness when accessing string fields.

dseeni · Sep 26, 2024 · a0f21b9 · a0f21b9
1 parent 6e44757
commit a0f21b9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/aeron-agent/src/main/java/io/aeron/agent/ArchiveEventDissector.java b/aeron-agent/src/main/java/io/aeron/agent/ArchiveEventDissector.java
@@ -535,11 +535,11 @@ static void dissectReplaySessionStateChange(
         builder.append(" position=").append(position);
 
         builder.append(" ");
-        absoluteOffset += buffer.getStringAscii(absoluteOffset, builder);
+        absoluteOffset += buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
         absoluteOffset += SIZE_OF_INT;
 
         builder.append(" reason=\"");
-        buffer.getStringAscii(absoluteOffset, builder);
+        buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
         builder.append("\"");
     }
 
@@ -558,11 +558,11 @@ static void dissectRecordingSessionStateChange(
         builder.append(" position=").append(position);
 
         builder.append(" ");
-        absoluteOffset += buffer.getStringAscii(absoluteOffset, builder);
+        absoluteOffset += buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
         absoluteOffset += SIZE_OF_INT;
 
         builder.append(" reason=\"");
-        buffer.getStringAscii(absoluteOffset, builder);
+        buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
         builder.append("\"");
     }
 
@@ -587,11 +587,11 @@ static void dissectReplicationSessionStateChange(
         builder.append(" position=").append(position);
 
         builder.append(" ");
-        absoluteOffset += buffer.getStringAscii(absoluteOffset, builder);
+        absoluteOffset += buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
         absoluteOffset += SIZE_OF_INT;
 
         builder.append(" reason=\"");
-        buffer.getStringAscii(absoluteOffset, builder);
+        buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
         builder.append("\"");
     }
 
@@ -606,7 +606,7 @@ static void dissectControlSessionStateChange(
 
         builder.append(": controlSessionId=").append(controlSessionId);
         builder.append(" ");
-        buffer.getStringAscii(absoluteOffset, builder);
+        buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
     }
 
     static void dissectReplaySessionError(
@@ -624,7 +624,7 @@ static void dissectReplaySessionError(
         builder.append(": sessionId=").append(sessionId);
         builder.append(" recordingId=").append(recordingId);
         builder.append(" errorMessage=");
-        buffer.getStringAscii(absoluteOffset, builder);
+        buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
     }
 
     static void dissectCatalogResize(

diff --git a/aeron-agent/src/main/java/io/aeron/agent/ClusterEventDissector.java b/aeron-agent/src/main/java/io/aeron/agent/ClusterEventDissector.java
@@ -120,7 +120,7 @@ static void dissectStateChange(
 
         builder.append(": memberId=").append(memberId);
         builder.append(' ');
-        buffer.getStringAscii(absoluteOffset, builder);
+        buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
     }
 
     static void dissectNoOp(
@@ -157,7 +157,7 @@ static void dissectElectionStateChange(
         absoluteOffset += SIZE_OF_INT;
 
         builder.append(": memberId=").append(memberId).append(' ');
-        absoluteOffset += SIZE_OF_INT + buffer.getStringAscii(absoluteOffset, builder);
+        absoluteOffset += SIZE_OF_INT + buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
 
         builder.append(" leaderId=").append(leaderId);
         builder.append(" candidateTermId=").append(candidateTermId);
@@ -167,7 +167,7 @@ static void dissectElectionStateChange(
         builder.append(" appendPosition=").append(appendPosition);
         builder.append(" catchupPosition=").append(catchupPosition);
         builder.append(" reason=");
-        buffer.getStringAscii(absoluteOffset, builder);
+        buffer.getStringAscii(absoluteOffset, builder, LITTLE_ENDIAN);
     }
 
     static void dissectCanvassPosition(

diff --git a/aeron-agent/src/main/java/io/aeron/agent/CommonEventDissector.java b/aeron-agent/src/main/java/io/aeron/agent/CommonEventDissector.java
@@ -92,7 +92,7 @@ static int dissectInetAddress(final MutableDirectBuffer buffer, final int offset
     {
         int encodedLength = 0;
 
-        final int addressLength = buffer.getInt(offset + encodedLength);
+        final int addressLength = buffer.getInt(offset + encodedLength, LITTLE_ENDIAN);
         encodedLength += SIZE_OF_INT;
 
         if (4 == addressLength)