Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions for builds and releases #174

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

mdouchement
Copy link
Contributor

@mdouchement mdouchement commented Apr 19, 2023

This PR addresses the issue #172:

VST part is omitted/disabled due to my lack of .NET knowledge but it can be fixed in another PR by someone else.

@mikeoliphant
Copy link
Collaborator

VST part is omitted/disabled due to my lack of .NET knowledge but it can be fixed in another PR by someone else.

I think the VST gets installed by the installer.

@erikgitarristen
Copy link

The vst does not install while using this installer. Could it be possible to update the vst to read the files from the latest liveSPICE? It seems that the vst can't cope with the new electrical components in the latest liveSPICE, or am i doing something wrong?

@mikeoliphant
Copy link
Collaborator

VST part is omitted/disabled due to my lack of .NET knowledge but it can be fixed in another PR by someone else.

I think the VST gets installed by the installer.

Ah - just noticed that you commented it out of the installer config. I'll have a look at it.

@mikeoliphant
Copy link
Collaborator

@mdouchement Just change "net5.0-windows" to "net6.0-windows" in the VST install lines, and it should work.

@mikeoliphant
Copy link
Collaborator

Looks good!

@dsharlet any objections to merging?

@dsharlet
Copy link
Owner

This looks great, thank you for doing this, and @mikeoliphant for the review and VST support!

@dsharlet dsharlet merged commit 0195048 into dsharlet:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants