Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to save schematics atomically #219

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Attempt to save schematics atomically #219

merged 2 commits into from
Feb 1, 2024

Conversation

dsharlet
Copy link
Owner

Hopefully this helps the VST plugin to watch the file system more easily (#217).

@kostoskistefan
Copy link
Contributor

This looks and works great, just one small thing. If the MoveFileEx fails, the .temp file should be removed, if i'm not mistaken.

@dsharlet
Copy link
Owner Author

dsharlet commented Feb 1, 2024

I thought about that, I think I'm just going to leave it. I think failures of this will be extremely rare, and if it does fail, it might be useful as a way to recover from a failed save.

@dsharlet dsharlet merged commit 8e5086a into master Feb 1, 2024
2 checks passed
@dsharlet dsharlet deleted the atomic-save branch February 1, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants