refactor(compiler): rename diagnostics/src/code.ts to diagnostics/src…

…/error_code.ts (angular#35067) the new filename is less ambiguous and better reflects the name of the symbol defined in it. PR Close angular#35067
dsln · Jan 31, 2020 · c070037 · c070037
1 parent a4cacb5
commit c070037
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/packages/compiler-cli/src/ngtsc/diagnostics/index.ts b/packages/compiler-cli/src/ngtsc/diagnostics/index.ts
@@ -6,6 +6,6 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-export {ErrorCode, ngErrorCode} from './src/code';
 export {FatalDiagnosticError, isFatalDiagnosticError, makeDiagnostic} from './src/error';
+export {ErrorCode, ngErrorCode} from './src/error_code';
 export {replaceTsWithNgInErrors} from './src/util';
diff --git a/packages/compiler-cli/src/ngtsc/diagnostics/src/error.ts b/packages/compiler-cli/src/ngtsc/diagnostics/src/error.ts
@@ -8,7 +8,7 @@
 
 import * as ts from 'typescript';
 
-import {ErrorCode} from './code';
+import {ErrorCode} from './error_code';
 
 export class FatalDiagnosticError {
   constructor(readonly code: ErrorCode, readonly node: ts.Node, readonly message: string) {}

diff --git a/...ler-cli/src/ngtsc/diagnostics/src/code.ts → ...i/src/ngtsc/diagnostics/src/error_code.ts b/...ler-cli/src/ngtsc/diagnostics/src/code.ts → ...i/src/ngtsc/diagnostics/src/error_code.ts
@@ -6,6 +6,9 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+/**
+ * @publicApi
+ */
 export enum ErrorCode {
   DECORATOR_ARG_NOT_LITERAL = 1001,
   DECORATOR_ARITY_WRONG = 1002,
@@ -125,6 +128,9 @@ export enum ErrorCode {
   INJECTABLE_DUPLICATE_PROV = 9001,
 }
 
+/**
+ * @internal
+ */
 export function ngErrorCode(code: ErrorCode): number {
   return parseInt('-99' + code);
 }
diff --git a/tools/public_api_guard/BUILD.bazel b/tools/public_api_guard/BUILD.bazel
@@ -69,7 +69,7 @@ ts_api_guardian_test(
 # explicit target because the d.ts file is nested in the core and not part of typical public d.ts api
 ts_api_guardian_test(
     name = "error_code_api",
-    actual = "angular/packages/compiler-cli/src/ngtsc/diagnostics/src/code.d.ts",
+    actual = "angular/packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.d.ts",
     data = [
         ":error_code.d.ts",
         "//packages/compiler-cli/src/ngtsc/diagnostics",