-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: get images in spolier tags for QuestionableQuesting
See: #1141
- Loading branch information
Showing
1 changed file
with
15 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just an FYI here, there are images that will load on site but fail to load under this change. It should be fairly rare, however, it isn't impossible another ticket might appear for images which loaded under proxy may appear in the future.
QQ's proxy includes long term caching of images, and some number of stories hotlink to images links which require a time-limited token to access. These tokens are usually expired by the time you view the image, hence the proxy/cache method they use - You can imagine where this would be an issue. There are a number of other cases where the original image uri isn't available yet the image is shown on page.
I can't give any URLs where this is the case off the top of my head, and this solution should work for most instances.