tests for full fit-in

dthadi3 · Jul 10, 2014 · d01eb79 · d01eb79
1 parent 9101ee4
commit d01eb79
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/tests/test_cryptourl.py b/tests/test_cryptourl.py
@@ -128,7 +128,7 @@ def test_decryption_fit_in():
     '''
 
     crypto = CryptoURL(KEY)
-    url = crypto.generate(image_url=IMAGE_URL, fit_in=True, old=True)
+    url = crypto.generate(image_url=IMAGE_URL, fit_in=True, width=300, height=200, old=True)
     decrypted = decrypt_in_thumbor(url)
 
     assert decrypted['fit_in'] == True

diff --git a/tests/test_url_composer.py b/tests/test_url_composer.py
@@ -235,7 +235,7 @@ def test_fit_in_fails_if_no_width_supplied():
     except ValueError:
         err = sys.exc_info()[1]
         assert err is not None
-    finally:
+    else:
         assert False, "Should not have gotten this far"
 
 def test_full_fit_in_fails_if_no_width_supplied():
@@ -244,7 +244,7 @@ def test_full_fit_in_fails_if_no_width_supplied():
     except ValueError:
         err = sys.exc_info()[1]
         assert err is not None
-    finally:
+    else:
         assert False, "Should not have gotten this far"
 
 def test_adaptive_fit_in_fails_if_no_width_supplied():
@@ -253,7 +253,7 @@ def test_adaptive_fit_in_fails_if_no_width_supplied():
     except ValueError:
         err = sys.exc_info()[1]
         assert err is not None
-    finally:
+    else:
         assert False, "Should not have gotten this far"
 
 def test_adaptive_full_fit_in_fails_if_no_width_supplied():
@@ -262,11 +262,9 @@ def test_adaptive_full_fit_in_fails_if_no_width_supplied():
     except ValueError:
         err = sys.exc_info()[1]
         assert err is not None
-    finally:
+    else:
         assert False, "Should not have gotten this far"
 
-
-
 def test_full_fit_in_url():
     '''test_full_fit_in_url
     Given