Skip to content

Commit

Permalink
ovs/geneve: fix rtnl notifications on iface deletion
Browse files Browse the repository at this point in the history
The function geneve_dev_create_fb() (only used by ovs) never calls
rtnl_configure_link(). The consequence is that dev->rtnl_link_state is
never set to RTNL_LINK_INITIALIZED.
During the deletion phase, the function rollback_registered_many() sends
a RTM_DELLINK only if dev->rtnl_link_state is set to RTNL_LINK_INITIALIZED.

Fixes: e305ac6 ("geneve: Add support to collect tunnel metadata.")
CC: Pravin B Shelar <[email protected]>
CC: Jesse Gross <[email protected]>
CC: Thomas Graf <[email protected]>
Signed-off-by: Nicolas Dichtel <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
NicolasDichtel authored and davem330 committed Jun 15, 2016
1 parent da6f1da commit 4100948
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/net/geneve.c
Original file line number Diff line number Diff line change
Expand Up @@ -1532,6 +1532,10 @@ struct net_device *geneve_dev_create_fb(struct net *net, const char *name,
if (err)
goto err;

err = rtnl_configure_link(dev, NULL);
if (err < 0)
goto err;

return dev;

err:
Expand Down

0 comments on commit 4100948

Please sign in to comment.