Add quick build option to disable checkstyle and error-prone (apache#685

)
dujl · Dec 5, 2019 · 6233d7a · 6233d7a
1 parent d70a631
commit 6233d7a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 19 deletions.
diff --git a/baseline.gradle b/baseline.gradle
@@ -32,8 +32,10 @@ subprojects {
   // Thus we concede to applying all of the Baseline plugins individually on all the projects we are
   // ready to enforce linting on.
   apply plugin: 'org.inferred.processors'
-  apply plugin: 'com.palantir.baseline-checkstyle'
-  apply plugin: 'com.palantir.baseline-error-prone'
+  if (!project.hasProperty('quick')) {
+    apply plugin: 'com.palantir.baseline-checkstyle'
+    apply plugin: 'com.palantir.baseline-error-prone'
+  }
   apply plugin: 'com.palantir.baseline-scalastyle'
   apply plugin: 'com.palantir.baseline-class-uniqueness'
   apply plugin: 'com.palantir.baseline-reproducibility'
@@ -58,21 +60,23 @@ subprojects {
     }
   }
 
-  tasks.withType(JavaCompile).configureEach {
-    options.errorprone.errorproneArgs += [
-        // error-prone is slow, don't run on tests
-        '-XepExcludedPaths:.*/test/.*',
-        // specific to Palantir
-        '-Xep:PreferSafeLoggingPreconditions:OFF',
-        '-Xep:PreferSafeLoggableExceptions:OFF',
-        '-Xep:Slf4jLogsafeArgs:OFF',
-        // subclasses are not equal
-        '-Xep:EqualsGetClass:OFF',
-        // patterns that are allowed
-        '-Xep:SwitchStatementDefaultCase:OFF',
-        '-Xep:MissingCasesInEnumSwitch:OFF',
-        '-Xep:TypeParameterShadowing:OFF',
-        '-Xep:TypeParameterUnusedInFormals:OFF',
-      ]
+  pluginManager.withPlugin('com.palantir.baseline-error-prone') {
+    tasks.withType(JavaCompile).configureEach {
+      options.errorprone.errorproneArgs += [
+          // error-prone is slow, don't run on tests
+          '-XepExcludedPaths:.*/test/.*',
+          // specific to Palantir
+          '-Xep:PreferSafeLoggingPreconditions:OFF',
+          '-Xep:PreferSafeLoggableExceptions:OFF',
+          '-Xep:Slf4jLogsafeArgs:OFF',
+          // subclasses are not equal
+          '-Xep:EqualsGetClass:OFF',
+          // patterns that are allowed
+          '-Xep:SwitchStatementDefaultCase:OFF',
+          '-Xep:MissingCasesInEnumSwitch:OFF',
+          '-Xep:TypeParameterShadowing:OFF',
+          '-Xep:TypeParameterUnusedInFormals:OFF',
+        ]
+    }
   }
 }
diff --git a/jmh.gradle b/jmh.gradle
@@ -32,7 +32,9 @@ configure(jmhProjects) {
   }
 
   jmhCompileGeneratedClasses {
-    options.errorprone.enabled = false
+    pluginManager.withPlugin('com.palantir.baseline-error-prone') {
+      options.errorprone.enabled = false
+    }
   }
 }