Skip to content

Commit

Permalink
Removed compiled groovy classes from hq.jar (causing classloading iss…
Browse files Browse the repository at this point in the history
…ues with ui plugins)
  • Loading branch information
Jennifer Hickey committed Oct 8, 2009
1 parent 4f6e1fe commit e550da4
Show file tree
Hide file tree
Showing 20 changed files with 32 additions and 19 deletions.
2 changes: 2 additions & 0 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,8 @@
<exclude name="org/hyperic/hq/plugin/**"/>
<!-- Exclude unit tests -->
<exclude name="org/hyperic/**/*_test*"/>
<!-- Exclude groovy classes -->
<exclude name="org/hyperic/hq/hqu/rendit/**"/>
</jar>

<!-- We only want server and shared classes for the UI -->
Expand Down
4 changes: 3 additions & 1 deletion build_util/hqu-build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<fileset dir="${rendit_sys.dir}">
<include name="**/*.groovy" />
<include name="**/*.properties" />
<exclude name="**/*.java" />
</fileset>
</copy>
<mkdir dir="@{wardir}/hqu" />
Expand All @@ -26,6 +25,9 @@
<exclude name="scaffold/**" />
<exclude name="extra/**" />
<exclude name="old/**" />
<exclude name="**/.classpath"/>
<exclude name="**/.project"/>
<exclude name="**/bin/**"/>
</fileset>
</copy>
</sequential>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.hyperic.dao.DAOFactory;
import org.hyperic.hq.appdef.shared.AppdefEntityID;
import org.hyperic.hq.application.HQApp;
import org.hyperic.hq.application.Scheduler;
Expand All @@ -71,7 +70,7 @@
import org.hyperic.hq.events.InvalidActionDataException;
import org.hyperic.hq.events.Notify;
import org.hyperic.hq.events.server.session.AlertRegulator;
import org.hyperic.hq.hqu.rendit.RenditServer;
import org.hyperic.hq.hqu.RenditServer;
import org.hyperic.hq.measurement.MeasurementNotFoundException;
import org.hyperic.util.ConfigPropertyException;
import org.hyperic.util.StringUtil;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
import org.hyperic.hq.events.AlertDefinitionInterface;
import org.hyperic.hq.events.AlertInterface;
import org.hyperic.hq.events.InvalidActionDataException;
import org.hyperic.hq.hqu.rendit.RenditServer;
import org.hyperic.hq.hqu.RenditServer;
import org.hyperic.util.config.ConfigResponse;
import org.hyperic.util.config.ConfigSchema;
import org.hyperic.util.config.InvalidOptionException;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,13 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
* USA.
*/
package org.hyperic.hq.hqu.rendit;
package org.hyperic.hq.hqu;

import java.io.File;
import java.util.Properties;

import org.hyperic.hq.authz.server.session.AuthzSubject;
import org.hyperic.hq.authz.server.session.Resource;
import org.hyperic.hq.hqu.AttachmentDescriptor;
import org.hyperic.hq.hqu.server.session.Attachment;
import org.hyperic.hq.hqu.server.session.UIPlugin;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
* USA.
*/
package org.hyperic.hq.hqu.rendit;
package org.hyperic.hq.hqu;

import java.io.File;
import java.util.Properties;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
* USA.
*/
package org.hyperic.hq.hqu.rendit;
package org.hyperic.hq.hqu;

import java.util.List;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
* USA.
*/
package org.hyperic.hq.hqu.rendit;
package org.hyperic.hq.hqu;

public class PluginLoadException
extends RuntimeException
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
* USA.
*/
package org.hyperic.hq.hqu.rendit;
package org.hyperic.hq.hqu;

import groovy.lang.GroovyClassLoader;

Expand All @@ -41,6 +41,7 @@
import org.hyperic.hq.authz.server.session.Resource;
import org.hyperic.hq.common.SystemException;
import org.hyperic.hq.hqu.AttachmentDescriptor;
import org.hyperic.hq.hqu.IDispatcher;
import org.hyperic.hq.hqu.server.session.Attachment;
import org.hyperic.hq.hqu.server.session.UIPlugin;
import org.hyperic.util.Runnee;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
* USA.
*/
package org.hyperic.hq.hqu.rendit;
package org.hyperic.hq.hqu;

import java.io.File;
import java.io.Writer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
* USA.
*/
package org.hyperic.hq.hqu.rendit;
package org.hyperic.hq.hqu;

import javax.servlet.ServletContext;
import javax.servlet.http.HttpServletRequest;
Expand Down
3 changes: 3 additions & 0 deletions src/org/hyperic/hq/hqu/rendit/BaseController.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@ import org.hyperic.hq.hqu.rendit.helpers.MetricHelper
import org.hyperic.hq.hqu.rendit.helpers.UserHelper
import org.hyperic.hq.hqu.rendit.helpers.AutodiscoveryHelper
import org.hyperic.hq.hqu.rendit.helpers.RoleHelper

import org.hyperic.hq.hqu.RequestInvocationBindings;
import org.hyperic.hq.hqu.rendit.render.RenderFrame


import org.apache.commons.fileupload.servlet.ServletFileUpload
import org.apache.commons.fileupload.FileItemIterator
import org.apache.commons.fileupload.FileItemStream
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package org.hyperic.hq.hqu.rendit
import org.hyperic.hq.hqu.rendit.i18n.BundleMapFacade
import org.apache.commons.logging.Log
import org.apache.commons.logging.LogFactory
import org.hyperic.hq.hqu.RequestInvocationBindings

/**
* Called by the dispatcher to execute controller methods.
Expand Down
1 change: 1 addition & 0 deletions src/org/hyperic/hq/hqu/rendit/HQUPlugin.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import org.hyperic.hq.hqu.rendit.helpers.ResourceHelper
import org.hyperic.hq.hqu.server.session.Attachment
import org.hyperic.hq.hqu.server.session.UIPlugin
import org.hyperic.hq.hqu.AttachmentDescriptor
import org.hyperic.hq.hqu.IHQUPlugin;
import org.hyperic.hq.hqu.SimpleAttachmentDescriptor
import org.hyperic.hq.hqu.ViewDescriptor
import org.hyperic.hq.hqu.server.session.UIPluginManagerEJBImpl as PluginMan
Expand Down
6 changes: 4 additions & 2 deletions src/org/hyperic/hq/hqu/rendit/dispatcher.groovy
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package org.hyperic.hq.hqu.rendit

import org.codehaus.groovy.runtime.InvokerHelper
import groovy.lang.Script

import org.hyperic.hq.authz.server.session.AuthzSubject
import org.hyperic.hq.authz.server.session.Resource
import org.hyperic.hq.hqu.AttachmentDescriptor
import org.hyperic.hq.hqu.IDispatcher;
import org.hyperic.hq.hqu.IHQUPlugin;
import org.hyperic.hq.hqu.server.session.Attachment
import org.hyperic.hq.hqu.server.session.UIPlugin
import org.hyperic.hq.hqu.rendit.metaclass.AuthzSubjectCategory
Expand All @@ -21,6 +21,8 @@ import org.hyperic.hq.hqu.rendit.metaclass.ResourceGroupCategory
import org.hyperic.hq.hqu.rendit.metaclass.RoleCategory
import org.hyperic.hq.hqu.rendit.metaclass.StringCategory
import org.hyperic.hq.hqu.rendit.metaclass.AgentCategory
import org.hyperic.hq.hqu.InvokeMethodInvocationBindings
import org.hyperic.hq.hqu.RequestInvocationBindings

import org.apache.commons.logging.Log
import org.apache.commons.logging.LogFactory
Expand Down
3 changes: 3 additions & 0 deletions src/org/hyperic/hq/hqu/rendit/helpers/AgentHelper.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@ import org.hyperic.hq.appdef.server.session.AgentManagerEJBImpl as AgentMan
import org.hyperic.hq.authz.server.session.AuthzSubject
import org.hyperic.hq.appdef.shared.AgentNotFoundException


class AgentHelper extends BaseHelper {

private aMan = AgentMan.one



AgentHelper(AuthzSubject user) {
super(user)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
import org.hyperic.hq.context.Bootstrap;
import org.hyperic.hq.hqu.AttachmentDescriptor;
import org.hyperic.hq.hqu.ViewDescriptor;
import org.hyperic.hq.hqu.rendit.RenditServer;
import org.hyperic.hq.hqu.RenditServer;
import org.hyperic.hq.hqu.shared.UIPluginManagerLocal;
import org.hyperic.hq.hqu.shared.UIPluginManagerUtil;
import org.hyperic.hq.hqu.server.session.AttachType;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
import org.hyperic.hq.bizapp.server.session.SystemAudit;
import org.hyperic.hq.common.SystemException;
import org.hyperic.hq.context.Bootstrap;
import org.hyperic.hq.hqu.rendit.RenditServer;
import org.hyperic.hq.hqu.RenditServer;
import org.hyperic.hq.product.PluginException;
import org.hyperic.hq.product.PluginInfo;
import org.hyperic.hq.product.ProductPlugin;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
import org.hyperic.hq.appdef.server.session.ResourceDeletedZevent;
import org.hyperic.hq.application.HQApp;
import org.hyperic.hq.application.StartupListener;
import org.hyperic.hq.hqu.rendit.RenditServer;
import org.hyperic.hq.hqu.RenditServer;
import org.hyperic.hq.product.server.session.PluginsDeployedCallback;
import org.hyperic.hq.zevents.ZeventManager;
import org.hyperic.util.file.DirWatcher;
Expand Down
4 changes: 2 additions & 2 deletions src/org/hyperic/hq/ui/servlet/RenditServlet.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
import org.hyperic.hq.auth.shared.SessionException;
import org.hyperic.hq.authz.server.session.AuthzSubject;
import org.hyperic.hq.bizapp.server.session.AuthzBossEJBImpl;
import org.hyperic.hq.hqu.rendit.RenditServer;
import org.hyperic.hq.hqu.rendit.RequestInvocationBindings;
import org.hyperic.hq.hqu.RenditServer;
import org.hyperic.hq.hqu.RequestInvocationBindings;
import org.hyperic.hq.ui.util.RequestUtils;
import org.hyperic.util.StringUtil;

Expand Down

0 comments on commit e550da4

Please sign in to comment.