Skip to content

Commit

Permalink
Add TLS_FALLBACK_SCSV documentation, and move s_client -fallback_scsv
Browse files Browse the repository at this point in the history
handling out of #ifndef OPENSSL_NO_DTLS1 section.

Reviewed-by: Rich Salz <[email protected]>
  • Loading branch information
45264 committed Oct 15, 2014
1 parent cf6da05 commit fb0e87f
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 8 deletions.
8 changes: 4 additions & 4 deletions apps/s_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -942,10 +942,6 @@ static char *jpake_secret = NULL;
meth=DTLSv1_2_client_method();
socket_type=SOCK_DGRAM;
}
else if (strcmp(*argv,"-fallback_scsv") == 0)
{
fallback_scsv = 1;
}
else if (strcmp(*argv,"-timeout") == 0)
enable_timeouts=1;
else if (strcmp(*argv,"-mtu") == 0)
Expand All @@ -954,6 +950,10 @@ static char *jpake_secret = NULL;
socket_mtu = atol(*(++argv));
}
#endif
else if (strcmp(*argv,"-fallback_scsv") == 0)
{
fallback_scsv = 1;
}
else if (strcmp(*argv,"-keyform") == 0)
{
if (--argc < 1) goto bad;
Expand Down
14 changes: 10 additions & 4 deletions doc/apps/s_client.pod
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ B<openssl> B<s_client>
[B<-no_ssl2>]
[B<-no_ssl3>]
[B<-no_tls1>]
[B<-no_tls1_1>]
[B<-no_tls1_2>]
[B<-fallback_scsv>]
[B<-bugs>]
[B<-cipher cipherlist>]
[B<-serverpref>]
Expand Down Expand Up @@ -245,16 +248,19 @@ Use the PSK key B<key> when using a PSK cipher suite. The key is
given as a hexadecimal number without leading 0x, for example -psk
1a2b3c4d.

=item B<-ssl2>, B<-ssl3>, B<-tls1>, B<-no_ssl2>, B<-no_ssl3>, B<-no_tls1>
=item B<-ssl2>, B<-ssl3>, B<-tls1>, B<-no_ssl2>, B<-no_ssl3>, B<-no_tls1>, B<-no_tls1_1>, B<-no_tls1_2>

these options disable the use of certain SSL or TLS protocols. By default
the initial handshake uses a method which should be compatible with all
servers and permit them to use SSL v3, SSL v2 or TLS as appropriate.

Unfortunately there are a lot of ancient and broken servers in use which
Unfortunately there are still ancient and broken servers in use which
cannot handle this technique and will fail to connect. Some servers only
work if TLS is turned off with the B<-no_tls> option others will only
support SSL v2 and may need the B<-ssl2> option.
work if TLS is turned off.

=item B<-fallback_scsv>

Send TLS_FALLBACK_SCSV in the ClientHello.

=item B<-bugs>

Expand Down
6 changes: 6 additions & 0 deletions doc/ssl/SSL_CTX_set_mode.pod
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ SSL_CTX->freelist_max_len, which defaults to 32. Using this flag can
save around 34k per idle SSL connection.
This flag has no effect on SSL v2 connections, or on DTLS connections.

=item SSL_MODE_FALLBACK_SCSV

Send TLS_FALLBACK_SCSV in the ClientHello.
To be set by applications that reconnect with a downgraded protocol
version; see draft-ietf-tls-downgrade-scsv-00 for details.

=back

=head1 RETURN VALUES
Expand Down

0 comments on commit fb0e87f

Please sign in to comment.