Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast limit in get_authentication_log to a string #287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MartijnBl
Copy link

The API endpoint expects limit to be a string.

Cast the limit to a sting before sending off the API request

Description

Cast the limit to a sting before sending off the API request

Motivation and Context

A user of the api lib would reasonably expect a limit to be an int, not a string. Arguable the endpoint will probably cast this back to an int straight away :)

How Has This Been Tested?

Locally tested

Types of Changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

The API endpoint expects limit to be a string.
@MartijnBl MartijnBl changed the title Cast limit in to a string get_authentication_logcast limit in Cast limit in get_authentication_log to a string Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant