Fix to gracefully handle a tags without hrefs

dustinlarimer · Mar 7, 2018 · bf481b5 · bf481b5
1 parent 7500e19
commit bf481b5
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 10 deletions.
diff --git a/dist/keen-tracking.js b/dist/keen-tracking.js
diff --git a/dist/keen-tracking.min.js b/dist/keen-tracking.min.js
diff --git a/lib/helpers/getDomNodeProfile.js b/lib/helpers/getDomNodeProfile.js
@@ -4,7 +4,7 @@ function getDomNodeProfile(el) {
   return {
     action: el.action,
     class: el.className,
-    href: el.href,
+    href: el.href || null,
     id: el.id,
     method: el.method,
     name: el.name,

diff --git a/lib/utils/listener.js b/lib/utils/listener.js
@@ -208,9 +208,11 @@ function deferClickEvent(evt, anchor, callback){
       evt.preventDefault();
     }
     evt.returnValue = false;
-    setTimeout(function(){
-      window.location = anchor.href;
-    }, timeout);
+    if (anchor.href) {
+      setTimeout(function(){
+        window.location = anchor.href;
+      }, timeout);
+    }
   }
 
   return false;