Merge pull request #90 from DanTalash/master

Using relative screenshot path instead of a hardcoded folder
dutchiexl · Jun 12, 2018 · 878084a · 878084a
2 parents 618bb31 + 923cffe
commit 878084a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/Classes/Scenario.php b/src/Classes/Scenario.php
@@ -198,8 +198,10 @@ public function setScreenshotPath($string)
      */
     public function getScreenshotPath()
     {
-        if (file_exists('results/html/' . $this->screenshotPath)) {
-            return $this->screenshotPath;
+        if (file_exists($this->screenshotPath)) {
+            return "file://" . realpath($this->screenshotPath);
         }
+
+        return false;
     }
 }
diff --git a/src/Formatter/BehatHTMLFormatter.php b/src/Formatter/BehatHTMLFormatter.php
@@ -470,7 +470,8 @@ public function onBeforeScenarioTested(BeforeScenarioTested $event)
         $scenario->setLine($event->getScenario()->getLine());
         $scenario->setScreenshotName($event->getScenario()->getTitle());
         $scenario->setScreenshotPath(
-            'assets/screenshots/' .
+            $this->printer->getOutputPath() .
+            '/assets/screenshots/' .
             preg_replace('/\W/', '', $event->getFeature()->getTitle()) . '/'.
             preg_replace('/\W/', '', $event->getScenario()->getTitle()) . '.png'
         );