Skip to content

Commit

Permalink
fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
chentsulin committed Mar 3, 2016
1 parent fab6e90 commit 31462ce
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 25 deletions.
9 changes: 3 additions & 6 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@
"node": true
},
"rules": {
"react/jsx-uses-react": 2,
"react/jsx-uses-vars": 2,
"react/react-in-jsx-scope": 2,
"react/jsx-no-bind": 0,

"no-var": 0,
"vars-on-top": 0,
"comma-dangle": 0,
"no-use-before-define": 0
"no-use-before-define": 0,
"consistent-return": 0
},
"plugins": [
"react"
Expand Down
4 changes: 1 addition & 3 deletions test/components/Counter.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ function setup() {
return {
component,
actions,
buttons: scryRenderedDOMComponentsWithTag(component, 'button').map(button => {
return button;
}),
buttons: scryRenderedDOMComponentsWithTag(component, 'button').map(button => button),
p: findRenderedDOMComponentWithClass(component, 'counter')
};
}
Expand Down
4 changes: 1 addition & 3 deletions test/containers/CounterPage.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ function setup(initialState) {
);
return {
app,
buttons: scryRenderedDOMComponentsWithTag(app, 'button').map(button => {
return button;
}),
buttons: scryRenderedDOMComponentsWithTag(app, 'button').map(button => button),
p: findRenderedDOMComponentWithClass(app, 'counter')
};
}
Expand Down
14 changes: 6 additions & 8 deletions test/e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('main window', function spec() {
.withCapabilities({
chromeOptions: {
binary: electronPath,
args: ['app=' + path.resolve()]
args: [`app=${path.resolve()}`]
}
})
.forBrowser('electron')
Expand All @@ -32,13 +32,9 @@ describe('main window', function spec() {
await this.driver.quit();
});

const findCounter = () => {
return this.driver.findElement(webdriver.By.className(counterStyles.counter));
};
const findCounter = () => this.driver.findElement(webdriver.By.className(counterStyles.counter));

const findButtons = () => {
return this.driver.findElements(webdriver.By.className(counterStyles.btn));
};
const findButtons = () => this.driver.findElements(webdriver.By.className(counterStyles.btn));

it('should open window', async () => {
const title = await this.driver.getTitle();
Expand Down Expand Up @@ -101,7 +97,9 @@ describe('main window', function spec() {
});

it('should back to home if back button clicked', async () => {
const link = await this.driver.findElement(webdriver.By.css(`.${counterStyles.backButton} > a`));
const link = await this.driver.findElement(
webdriver.By.css(`.${counterStyles.backButton} > a`)
);
link.click();

await this.driver.findElement(webdriver.By.className(homeStyles.container));
Expand Down
3 changes: 2 additions & 1 deletion webpack.config.base.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ module.exports = {

],
externals: [
// put your node 3rd party libraries which can't be built with webpack here (mysql, mongodb, and so on..)
// put your node 3rd party libraries which can't be built with webpack here
// (mysql, mongodb, and so on..)
]
};
4 changes: 2 additions & 2 deletions webpack.config.development.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ config.plugins.push(
new webpack.HotModuleReplacementPlugin(),
new webpack.NoErrorsPlugin(),
new webpack.DefinePlugin({
'__DEV__': true,
__DEV__: true,
'process.env': {
'NODE_ENV': JSON.stringify('development')
NODE_ENV: JSON.stringify('development')
}
})
);
Expand Down
4 changes: 2 additions & 2 deletions webpack.config.production.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ config.module.loaders.push({
config.plugins.push(
new webpack.optimize.OccurenceOrderPlugin(),
new webpack.DefinePlugin({
'__DEV__': false,
__DEV__: false,
'process.env': {
'NODE_ENV': JSON.stringify('production')
NODE_ENV: JSON.stringify('production')
}
}),
new webpack.optimize.UglifyJsPlugin({
Expand Down

0 comments on commit 31462ce

Please sign in to comment.