Issue 87: Stack efficient Euclidean method

duynguyenkhac · Apr 25, 2020 · 46513c9 · 46513c9
1 parent eb2cd79
commit 46513c9
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/Algorithms/Numeric/GreatestCommonDivisor.cs b/Algorithms/Numeric/GreatestCommonDivisor.cs
@@ -9,25 +9,22 @@ public static class GreatestCommonDivisor
         /// </summary>
         public static int FindGCDEuclidean(int a, int b)
         {
+            int t = 0;
+
             a = Math.Abs(a);
             b = Math.Abs(b);
 
             if (a == 0)
                 return b;
             if (b == 0)
                 return a;
-            if (a == b)
-                return a;
-
-            return Euclidean(a, b);
-        }
-
-        private static int Euclidean(int a, int b)
-        {
-            if (b == 0)
-                return a;
 
-            return Euclidean(b, a % b);
+            while (a % b != 0) {
+                t = b;
+                b = a % b;
+                a = t;
+            }
+            return b;
         }
 
         /// <summary>