Compatibility with ggplot2 3.6.0 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Jan 31, 2025
Comment on lines
+11
to
+13
| # expect_equal(unname(labs["x"]), "concat_qstart") | ||
| expect_equal(unname(labs["xend"]), "concat_qend") | ||
| expect_equal(unname(labs["y"]), "concat_tstart") | ||
| # expect_equal(unname(labs["y"]), "concat_tstart") |
There was a problem hiding this comment.
These tests are commented out because the new version reports the labels generated by the scales (instead of just those in the $labels slot) and aren't the same across versions. Visually, the plot is the same though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Apologies for not posting an issue first.
The ggplot2 package is planning an update for around May 2025 and a reverse dependency test identified a problem with the pafr package.
The details are explained in tidyverse/ggplot2#6290, but essentially ggplot2 doesn't populate the
plot$labelsfield before plot building anymore, which violates some test assumptions in this package.This PR changes the tests to be compatible with both versions of ggplot2.
You can test the changes yourself with the development version of ggplot2 (
pak::pak("tidyverse/ggplot2"))Best,
Teun