Skip to content

Commit

Permalink
Returning false from an expression-specific diagnoser is
Browse files Browse the repository at this point in the history
apparently not what you're supposed to do.

Swift SVN r30436
  • Loading branch information
rjmccall committed Jul 21, 2015
1 parent 4a062f9 commit d51a922
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Sema/CSDiag.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2572,7 +2572,7 @@ bool FailureDiagnosis::visitBinaryExpr(BinaryExpr *binop) {
// of independent type-checking; just use the standard diagnostics
// paths.
auto argExpr = dyn_cast<TupleExpr>(checkedArgExpr);
if (!argExpr) return false;
if (!argExpr) return diagnoseGeneralFailure();

auto argTuple = argExpr->getType()->getAs<TupleType>();

Expand Down

0 comments on commit d51a922

Please sign in to comment.