Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove annotations support #5

Merged
merged 26 commits into from
Aug 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3d14989
refactor: remove `doctrine/annotations`
pizzaminded Mar 17, 2024
d7cb047
refactor: remove `doctrine/annotations` from ItemMappingReader
pizzaminded Mar 17, 2024
c50c25b
refactor: remove `doctrine/annotations` from ItemMappingReader
pizzaminded Mar 17, 2024
fc07e45
refactor: extract to separate method
pizzaminded Mar 17, 2024
af7ba49
refactor: remove more occurences of annotation reader
pizzaminded Mar 17, 2024
2732b7f
fix: remove annotation reader from test suite
pizzaminded Mar 17, 2024
05bbf23
refactor: change constructor arguments
pizzaminded Mar 17, 2024
cebb2e7
fix: switch test class from annotations to attributes
pizzaminded Mar 17, 2024
0b58675
fix: no need to keep these files in separate file
pizzaminded Mar 17, 2024
382dea6
fix: switch test class from annotations to attributes
pizzaminded Mar 17, 2024
29fca69
fix: switch test class from annotations to attributes
pizzaminded Mar 17, 2024
bad9faa
fix: get rid of AbstractAttribute
pizzaminded Mar 17, 2024
56c60ab
fix: switch test class from annotations to attributes
pizzaminded Mar 17, 2024
b9242d2
fix: define variable
pizzaminded Mar 17, 2024
39e5a94
refactor: remove last occurence of annotation reader
pizzaminded Mar 17, 2024
f283c2a
refactor: change constructor arguments
pizzaminded Mar 17, 2024
b954687
fix: switch test classes from annotations to attributes
pizzaminded Mar 17, 2024
5750db3
refactor: change constructor arguments
pizzaminded Mar 17, 2024
8167fb9
refactor: fix typehint
pizzaminded Mar 17, 2024
a110597
fix: switch test class from annotations to attributes
pizzaminded Mar 17, 2024
0a3041f
fix: change the function to split arrays
pizzaminded Jun 15, 2024
4a4c4b8
fix: convert `SetValue` to plain arrays during hydration
pizzaminded Jun 16, 2024
1f8a238
feat: add `nodash` filter
pizzaminded Jun 16, 2024
757c6fb
fix: get rid of annotations
pizzaminded Aug 17, 2024
e58c171
remove braces
pizzaminded Aug 17, 2024
23bfd13
update README.md
pizzaminded Aug 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: switch test class from annotations to attributes
  • Loading branch information
pizzaminded committed Mar 17, 2024
commit cebb2e73cf600378ac4e96dac75ccbfc35e7d64c
29 changes: 11 additions & 18 deletions tests/Dynamite/Fixtures/Valid/BankAccount.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,26 @@
namespace Dynamite\Fixtures\Valid;
use Dynamite\Configuration as Dynamite;

/**
* @Dynamite\Item(objectType="BANKACC")
* @Dynamite\PartitionKeyFormat("BANKACC#{id}")
* @Dynamite\SortKeyFormat("BANKACC")
*/
#[Dynamite\Item(objectType:"BANKACC")]
#[Dynamite\PartitionKeyFormat("BANKACC#{id}")]
#[Dynamite\SortKeyFormat("BANKACC")]
class BankAccount
{

/**
* @Dynamite\PartitionKey()
* @var string
*/
#[Dynamite\PartitionKey()]
private string $pk;

/**
* @Dynamite\SortKey()
* @var string
*/
#[Dynamite\SortKey()]
private string $sk;

/**
* @Dynamite\NestedValueObjectAttribute(type="Dynamite\Fixtures\Valid\CurrencyNestedValueObject", property="value", collection=true, name="cur")
* @var CurrencyNestedValueObject[]
*/
#[Dynamite\NestedValueObjectAttribute(
type: "Dynamite\Fixtures\Valid\CurrencyNestedValueObject",
name: "cur",
property: "value",
collection: true
)]
protected array $supportedCurrencies = [];

public function addSupportedCurrency(CurrencyNestedValueObject $currencyNestedValueObject)
Expand All @@ -42,7 +38,4 @@ public function getSupportedCurrencies(): array
{
return $this->supportedCurrencies;
}



}