Make sure that CFLAGS from the cmdline are honoured #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origin: Debian Bug: <URL to the upstream bug report if any, implies patch has been forwarded, optional> Forwarded: no Last-Update: 2025-01-11 Last-Update: 2025-01-11 Gbp-Pq: Name apply_CFLAGS.patch
jaromil
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both the
levelsand thethree_point_balancefilters require C99, and therefore add-std=c99to theCFLAGS.Unfortunately, they do so in a way that will ignore any CFLAGS set by the user (e.g. via envvars):
frei0r/src/filter/levels/CMakeLists.txt
Line 3 in 9178c72
a better way is of course to append the
-std=c99to any pre-existingCFLAGS.This is what this PR proposes.
background: in Debian, we set some additional hardening flags (totalling to
-D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection).Currently our flags are simply ignored (and thus our QA bails out), with the attached patch, everything works as it should.