Remove instance of anti-pattern when type checking (LLNL#109)

dyokelson · Nov 8, 2023 · abbce4e · abbce4e
1 parent 4d0b892
commit abbce4e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/thicket/tests/test_filter_stats.py b/thicket/tests/test_filter_stats.py
@@ -10,7 +10,7 @@ def check_filter_stats(th, columns_values):
     for column in columns_values:
         for value in columns_values[column]:
             # for type str column
-            if type(value) == str:
+            if isinstance(value, str):
                 # expected nodes after applying filter
                 exp_nodes = sorted(
                     th.statsframe.dataframe.index[
@@ -19,7 +19,7 @@ def check_filter_stats(th, columns_values):
                 )
                 new_th = th.filter_stats(lambda x: x[column] == value)
             # for type int column
-            elif type(value) == int:
+            elif isinstance(value, int):
                 exp_nodes = sorted(
                     th.statsframe.dataframe.index[
                         th.statsframe.dataframe[column] < value