make statistics forward-able

Summary: Make StatisticsImpl being able to forward stats to provided statistics implementation. The main purpose is to allow us to collect internal stats in the future even when user supplies custom statistics implementation. It avoids intrumenting 2 sets of stats collection code. One immediate use case is tuning advisor, which needs to collect some internal stats, users may not be interested. Test Plan: ran db_bench and see stats show up at the end of run Will run make all check since some tests rely on statistics Reviewers: yhchiang, sdong, igor Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D20145
dyu · Jul 28, 2014 · f6ca226 · f6ca226
1 parent 40fa8a4
commit f6ca226
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/db/db_impl.cc b/db/db_impl.cc
@@ -276,6 +276,7 @@ Options SanitizeOptions(const std::string& dbname,
 
 DBOptions SanitizeOptions(const std::string& dbname, const DBOptions& src) {
   DBOptions result = src;
+
   // result.max_open_files means an "infinite" open files.
   if (result.max_open_files != -1) {
     ClipToRange(&result.max_open_files, 20, 1000000);

diff --git a/util/statistics.h b/util/statistics.h
@@ -86,4 +86,5 @@ inline void SetTickerCount(Statistics* statistics, uint32_t ticker_type,
     statistics->setTickerCount(ticker_type, count);
   }
 }
+
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         statistics->setTickerCount(ticker_type, count);
       }
     }
     }