Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive directory watch #488

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add recursive directory watch #488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cbb8927
Add watch dir recursive option (missing python client regeneration)
dobrac Dec 2, 2024
fbdbddc
Update watch test file formatting
dobrac Dec 2, 2024
22a2894
Add python generated stubs
dobrac Dec 2, 2024
aaf7d4d
Improve watchDir jsSDK default value
dobrac Dec 2, 2024
981c024
Add recursive directory watching to the web documentation
dobrac Dec 2, 2024
378e633
Update documentation highlights
dobrac Dec 2, 2024
5fbb4de
Improve recursive watch tests and folders naming
dobrac Dec 2, 2024
262d80e
Regenerated python stubs with version 5.28.3
dobrac Dec 2, 2024
f847483
Test for recursive folder creation, add newline after code to docs
dobrac Dec 3, 2024
724e857
Run js tests cleanup using onTestFinished
dobrac Dec 3, 2024
af9b6dd
Add note to the recursive watch with rapid folder creation
dobrac Dec 19, 2024
8279c9d
Add recursive watch envd version check
dobrac Dec 19, 2024
e782f85
Add recursive watch envd version check python SDK, js SDK check
dobrac Dec 19, 2024
b5c8028
Cleanup tests only in debug
dobrac Dec 19, 2024
091ada1
JS SDK move version to object
dobrac Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve recursive watch tests and folders naming
  • Loading branch information
@dobrac
dobrac committed Dec 19, 2024
commit 5fbb4de48267039234741838abde4a46295c4e4c
6 changes: 3 additions & 3 deletions packages/js-sdk/tests/sandbox/files/watch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ sandboxTest('watch directory changes', async ({ sandbox }) => {
})

sandboxTest('watch recursive directory changes', async ({ sandbox }) => {
const dirname = 'test_watch_dir'
const dirname = 'test_recursive_watch_dir'
const nestedDirname = 'test_nested_watch_dir'
const filename = 'test_watch.txt'
const content = 'This file will be watched.'
Expand Down Expand Up @@ -64,8 +64,8 @@ sandboxTest('watch recursive directory changes', async ({ sandbox }) => {
await handle.stop()
})

sandboxTest('watch recursive directory folder addition', async ({ sandbox }) => {
const dirname = 'test_watch_dir'
sandboxTest('watch recursive directory after nested folder addition', async ({ sandbox }) => {
const dirname = 'test_recursive_watch_dir_add'
const nestedDirname = 'test_nested_watch_dir'
const filename = 'test_watch.txt'
const content = 'This file will be watched.'
Expand Down
6 changes: 3 additions & 3 deletions packages/python-sdk/tests/async/sandbox_async/files/test_watch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def handle_event(e: FilesystemEvent):


async def test_watch_recursive_directory_changes(async_sandbox: AsyncSandbox):
dirname = "test_watch_dir"
dirname = "test_recursive_watch_dir"
nested_dirname = "test_nested_watch_dir"
filename = "test_watch.txt"
content = "This file will be watched."
Expand All @@ -63,8 +63,8 @@ def handle_event(e: FilesystemEvent):
await handle.stop()


async def test_watch_recursive_directory_folder_addition(async_sandbox: AsyncSandbox):
dirname = "test_watch_dir"
async def test_watch_recursive_directory_after_nested_folder_addition(async_sandbox: AsyncSandbox):
dirname = "test_recursive_watch_dir_add"
nested_dirname = "test_nested_watch_dir"
filename = "test_watch.txt"
content = "This file will be watched."
Expand Down
6 changes: 3 additions & 3 deletions packages/python-sdk/tests/sync/sandbox_sync/files/test_watch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_watch_iterated(sandbox: Sandbox):


def test_watch_recursive_directory_changes(sandbox: Sandbox):
dirname = "test_watch_dir"
dirname = "test_recursive_watch_dir"
nested_dirname = "test_nested_watch_dir"
filename = "test_watch.txt"
content = "This file will be watched."
Expand All @@ -69,8 +69,8 @@ def test_watch_recursive_directory_changes(sandbox: Sandbox):
handle.stop()


def test_watch_recursive_directory_folder_addition(sandbox: Sandbox):
dirname = "test_watch_dir"
def test_watch_recursive_directory_after_nested_folder_addition(sandbox: Sandbox):
dirname = "test_recursive_watch_dir_add"
nested_dirname = "test_nested_watch_dir"
filename = "test_watch.txt"
content = "This file will be watched."
Expand Down