Accessibility: function _title_html, replaced <div> with H2, enclosed…

… <div> to <span> - now validates!
eSrem · Feb 28, 2006 · 02db7f7 · 02db7f7
1 parent b6f30b1
commit 02db7f7
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/blocks/moodleblock.class.php b/blocks/moodleblock.class.php
@@ -237,10 +237,12 @@ function _print_shadow() {
     function _title_html() {
         global $CFG;
 
-        $title = '<div class="title">';
+        //Accessibility: validation, can't have <div> inside <h2>, use <span>.
+        $title = '<span class="title">';
 
         if (!empty($CFG->allowuserblockhiding)) {
-            $title .= '<div class="hide-show"><a href="#" onclick="elementToggleHide(this, true, function(el) {return findParentNode(el, \'DIV\', \'sideblock\'); } ); return false;"><img src="'.$CFG->pixpath.'/spacer.gif" alt="" class="hide-show-image" /></a></div>';
+            //Accessibility: added static 'alt' text for the +- icon.
+            $title .= '<span class="hide-show"><a href="#" onclick="elementToggleHide(this, true, function(el) {return findParentNode(el, \'DIV\', \'sideblock\'); } ); return false;"><img src="'.$CFG->pixpath.'/spacer.gif" alt="hide OR show block" class="hide-show-image" /></a></span>';
         }
 
         $title .= $this->title;
@@ -249,7 +251,7 @@ function _title_html() {
             $title .= $this->edit_controls;
         }
 
-        $title .= '</div>';
+        $title .= '</span>';
 
         return $title;
     }