MDL-21781 fixed idnumber validation - thanks David for spotting the p…

…roblem
eSrem · May 31, 2010 · 0defeb1 · 0defeb1
1 parent 05a5434
commit 0defeb1
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/cohort/edit_form.php b/cohort/edit_form.php
@@ -68,13 +68,17 @@ public function validation($data, $files) {
         $errors = parent::validation($data, $files);
 
         $idnumber = trim($data['idnumber']);
-        if ($data['id']) {
+        if ($idnumber === '') {
+            // fine, empty is ok
+
+        } else if ($data['id']) {
             $current = $DB->get_record('cohort', array('id'=>$data['id']), '*', MUST_EXIST);
             if ($current->idnumber !== $idnumber) {
                 if ($DB->record_exists('cohort', array('idnumber'=>$idnumber))) {
                     $errors['idnumber'] = get_string('duplicateidnumber', 'cohort');
                 }
             }
+
         } else {
             if ($DB->record_exists('cohort', array('idnumber'=>$idnumber))) {
                 $errors['idnumber'] = get_string('duplicateidnumber', 'cohort');
@@ -105,4 +109,4 @@ protected function get_category_options($currentcontextid) {
         return $options;
     }
 }
-    
+