MDL-60682 forms: date/times should use step 1 minute by default

eSrem · Nov 21, 2017 · 223419d · 223419d
1 parent 4275ea4
commit 223419d
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/calendar/tests/calendartype_test.php b/calendar/tests/calendartype_test.php
@@ -221,9 +221,11 @@ private function convert_dateselector_to_unixtime_test($element, $type, $date) {
         $counter++;
 
         if ($element == 'dateselector') {
-            $el = $this->mform->addElement('date_selector', 'dateselector' . $counter, null, array('timezone' => 0.0, 'step' => 1));
+            $el = $this->mform->addElement('date_selector',
+                    'dateselector' . $counter, null, array('timezone' => 0.0));
         } else {
-            $el = $this->mform->addElement('date_time_selector', 'dateselector' . $counter, null, array('timezone' => 0.0, 'step' => 1, 'optional' => false));
+            $el = $this->mform->addElement('date_time_selector',
+                    'dateselector' . $counter, null, array('timezone' => 0.0, 'optional' => false));
         }
         $submitvalues = array('dateselector' . $counter => $date);
 

diff --git a/lib/form/dateselector.php b/lib/form/dateselector.php
@@ -79,7 +79,7 @@ public function __construct($elementName = null, $elementLabel = null, $options
         // Get the calendar type used - see MDL-18375.
         $calendartype = \core_calendar\type_factory::get_calendar_instance();
         $this->_options = array('startyear' => $calendartype->get_min_year(), 'stopyear' => $calendartype->get_max_year(),
-            'defaulttime' => 0, 'timezone' => 99, 'step' => 5, 'optional' => false);
+            'defaulttime' => 0, 'timezone' => 99, 'step' => 1, 'optional' => false);
         // TODO MDL-52313 Replace with the call to parent::__construct().
         HTML_QuickForm_element::__construct($elementName, $elementLabel, $attributes);
         $this->_persistantFreeze = true;

diff --git a/lib/form/datetimeselector.php b/lib/form/datetimeselector.php
@@ -81,7 +81,7 @@ public function __construct($elementName = null, $elementLabel = null, $options
         // Get the calendar type used - see MDL-18375.
         $calendartype = \core_calendar\type_factory::get_calendar_instance();
         $this->_options = array('startyear' => $calendartype->get_min_year(), 'stopyear' => $calendartype->get_max_year(),
-            'defaulttime' => 0, 'timezone' => 99, 'step' => 5, 'optional' => false);
+            'defaulttime' => 0, 'timezone' => 99, 'step' => 1, 'optional' => false);
 
         // TODO MDL-52313 Replace with the call to parent::__construct().
         HTML_QuickForm_element::__construct($elementName, $elementLabel, $attributes);

diff --git a/lib/form/defaultcustom.php b/lib/form/defaultcustom.php
@@ -77,7 +77,7 @@ public function __construct($elementname = null, $elementlabel = null, $options
             'startyear' => $calendartype->get_min_year(),
             'stopyear' => $calendartype->get_max_year(),
             'defaulttime' => 0,
-            'step' => 5,
+            'step' => 1,
             'optional' => false,
         ];
 

diff --git a/mod/quiz/mod_form.php b/mod/quiz/mod_form.php
@@ -37,7 +37,7 @@
  */
 class mod_quiz_mod_form extends moodleform_mod {
     /** @var array options to be used with date_time_selector fields in the quiz. */
-    public static $datefieldoptions = array('optional' => true, 'step' => 1);
+    public static $datefieldoptions = array('optional' => true);
 
     protected $_feedbacks;
     protected static $reviewfields = array(); // Initialised in the constructor.