MDL-60139 question manual grading: move code to reduce confusion

Move the variable definition closer to where it is used.
eSrem · Oct 30, 2017 · 284c795 · 284c795
1 parent 808b688
commit 284c795
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/question/behaviour/rendererbase.php b/question/behaviour/rendererbase.php
@@ -126,9 +126,6 @@ public function manual_comment_fields(question_attempt $qa, question_display_opt
             if (!is_null($currentmark)) {
                 $attributes['value'] = $currentmark;
             }
-            $a = new stdClass();
-            $a->max = $qa->format_max_mark($options->markdp);
-            $a->mark = html_writer::empty_tag('input', $attributes);
 
             $markrange = html_writer::empty_tag('input', array(
                 'type' => 'hidden',
@@ -152,6 +149,9 @@ public function manual_comment_fields(question_attempt $qa, question_display_opt
                         array('class' => 'error')) . html_writer::empty_tag('br');
             }
 
+            $a = new stdClass();
+            $a->max = $qa->format_max_mark($options->markdp);
+            $a->mark = html_writer::empty_tag('input', $attributes);
             $mark = html_writer::tag('div', html_writer::tag('div',
                         html_writer::tag('label', get_string('mark', 'question'),
                         array('for' => $markfield)),