MDL-24089 preventing any plugin upgrades if downgraded core detected;…

… localising error message

admin/cli/upgrade.php

@@ -77,7 +77,7 @@
 $CFG->target_release = $release;            // used during installation and upgrades
 
 if ($version < $CFG->version) {
-    cli_error('The code you are using is OLDER than the version that made these databases!'); // TODO: localize
+    cli_error(get_string('downgradedcore', 'error'));
 }
 
 $newversion = "$release ($version)";

admin/index.php

@@ -249,7 +249,8 @@
         upgrade_core($version, true);
     }
 } else if ($version < $CFG->version) {
-    echo $OUTPUT->notification('WARNING!!!  The code you are using is OLDER than the version that made these databases!');
+    // better stop here, we can not continue with plugin upgrades or anything else
+    throw new moodle_exception('downgradedcore', 'error', new moodle_url('/admin/'));
 }
 
 // Updated human-readable release version if necessary

lang/en/error.php

@@ -195,6 +195,7 @@
 $string['dmlreadexception'] = 'Error reading from database';
 $string['dmltransactionexception'] = 'Database transaction error';
 $string['dmlwriteexception'] = 'Error writing to database';
+$string['downgradedcore'] = 'ERROR!!!  The code you are using is OLDER than the version that made these databases!';
 $string['downloadedfilecheckfailed'] = 'Downloaded file check failed';
 $string['duplicateparaminsql'] = 'ERROR: duplicate parameter name in query';
 $string['duplicaterolename'] = 'There is already a role with this name!';