Prefer setFrom() over separate From and FromName

eakcantey · Sep 17, 2015 · 20112cc · 20112cc
1 parent 76619dd
commit 20112cc
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -82,8 +82,7 @@ $mail->Password = 'secret';                           // SMTP password
 $mail->SMTPSecure = 'tls';                            // Enable TLS encryption, `ssl` also accepted
 $mail->Port = 587;                                    // TCP port to connect to
 
-$mail->From = '[email protected]';
-$mail->FromName = 'Mailer';
+$mail->setFrom('[email protected]', 'Mailer');
 $mail->addAddress('[email protected]', 'Joe User');     // Add a recipient
 $mail->addAddress('[email protected]');               // Name is optional
 $mail->addReplyTo('[email protected]', 'Information');

diff --git a/docs/extending.html b/docs/extending.html
@@ -18,10 +18,9 @@ <h3>1. Advanced Example</h3>
 
 $mail = new PHPMailer();
 
-$mail->From     = '[email protected]';
-$mail->FromName = 'List manager';
-$mail->Host     = 'smtp1.example.com;smtp2.example.com';
-$mail->Mailer   = 'smtp';
+$mail->setFrom('[email protected]', 'List manager');
+$mail->Host   = 'smtp1.example.com;smtp2.example.com';
+$mail->Mailer = 'smtp';
 
 @mysqli_connect('localhost','root','password');
 @mysqli_select_db("my_company");

diff --git a/examples/code_generator.phps b/examples/code_generator.phps
@@ -117,21 +117,19 @@ try {
         try {
             if ($_POST['From_Name'] != '') {
                 $mail->addReplyTo($_POST['From_Email'], $_POST['From_Name']);
-                $mail->From = $_POST['From_Email'];
-                $mail->FromName = $_POST['From_Name'];
+                $mail->setFrom($_POST['From_Email'], $_POST['From_Name']);
 
                 $example_code .= "\n\$mail->addReplyTo(\"" .
                     $_POST['From_Email'] . "\", \"" . $_POST['From_Name'] . "\");";
-                $example_code .= "\n\$mail->From       = \"" . $_POST['From_Email'] . "\";";
-                $example_code .= "\n\$mail->FromName   = \"" . $_POST['From_Name'] . "\";";
+                $example_code .= "\n\$mail->setFrom(\"" .
+                    $_POST['From_Email'] . "\", \"" . $_POST['From_Name'] . "\");";
             } else {
                 $mail->addReplyTo($_POST['From_Email']);
-                $mail->From = $_POST['From_Email'];
-                $mail->FromName = $_POST['From_Email'];
+                $mail->setFrom($_POST['From_Email'], $_POST['From_Email']);
 
                 $example_code .= "\n\$mail->addReplyTo(\"" . $_POST['From_Email'] . "\");";
-                $example_code .= "\n\$mail->From       = \"" . $_POST['From_Email'] . "\";";
-                $example_code .= "\n\$mail->FromName   = \"" . $_POST['From_Email'] . "\";";
+                $example_code .= "\n\$mail->setFrom(\"" .
+                    $_POST['From_Email'] . "\", \"" . $_POST['From_Email'] . "\");";
             }
 
             if ($_POST['To_Name'] != '') {
@@ -162,7 +160,7 @@ try {
         }
         $mail->Subject = $_POST['Subject'] . ' (PHPMailer test using ' . strtoupper($_POST['test_type']) . ')';
         $example_code .= "\n\$mail->Subject  = \"" . $_POST['Subject'] .
-            '(PHPMailer test using ' . strtoupper($_POST['test_type']) . ')";';
+            ' (PHPMailer test using ' . strtoupper($_POST['test_type']) . ')";';
 
         if ($_POST['Message'] == '') {
             $body = file_get_contents('contents.html');
@@ -594,4 +592,4 @@ if (isset($_POST["submit"]) && $_POST["submit"] == "Submit") {
     </div>
 </form>
 </body>
-</html>
+</html>