Skip to content

Commit

Permalink
HTTP/2: enforce writing the sync request body buffer to file.
Browse files Browse the repository at this point in the history
The sync flag of HTTP/2 request body buffer is used when the size of request
body is unknown or bigger than configured "client_body_buffer_size".  In this
case the buffer points to body data inside the global receive buffer that is
used for reading all HTTP/2 connections in the worker process.  Thus, when the
sync flag is set, the buffer must be flushed to a temporary file, otherwise
the request body data can be overwritten.

Previously, the sync buffer wasn't flushed to a temporary file if the whole
body was received in one DATA frame with the END_STREAM flag and wasn't
copied into the HTTP/2 body preread buffer.  As a result, the request body
might be corrupted (ticket #1384).

Now, setting r->request_body_in_file_only enforces writing the sync buffer
to a temporary file in all cases.
  • Loading branch information
VBart committed Oct 4, 2017
1 parent d07d598 commit 328bfbe
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/http/v2/ngx_http_v2.c
Original file line number Diff line number Diff line change
Expand Up @@ -3589,11 +3589,6 @@ ngx_http_v2_read_request_body(ngx_http_request_t *r)
rb->buf = ngx_create_temp_buf(r->pool, (size_t) len);

} else {
if (stream->preread) {
/* enforce writing preread buffer to file */
r->request_body_in_file_only = 1;
}

rb->buf = ngx_calloc_buf(r->pool);

if (rb->buf != NULL) {
Expand Down Expand Up @@ -3694,6 +3689,8 @@ ngx_http_v2_process_request_body(ngx_http_request_t *r, u_char *pos,
buf->pos = buf->start = pos;
buf->last = buf->end = pos + size;

r->request_body_in_file_only = 1;

} else {
if (size > (size_t) (buf->end - buf->last)) {
ngx_log_error(NGX_LOG_INFO, fc->log, 0,
Expand Down

0 comments on commit 328bfbe

Please sign in to comment.