Skip Huawei labels when NFD patches a default namespace #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakiduck
reviewed
May 27, 2024
| - name: "ascend/atlas-800t-a2" | ||
| labels: | ||
| "host-arch": "huawei-arm" | ||
| "accelerator": "huawei-Ascend910" |
There was a problem hiding this comment.
node-role.kubernetes.io/worker=worker
workerselector=dls-worker-node
host-arch=huawei-arm或host-arch=huawei-x86
accelerator=huawei-Ascend910
需要以上四个标签
pkg/nfd-master/nfd-master.go
Outdated
| // containsHW returns true if the label contains Huawei's keys | ||
| func containsHW(src string) bool { | ||
| keys := []string{ | ||
| "accelerator", |
There was a problem hiding this comment.
@yakiduck 华为标签基本长期固定，另外nfd在operator中目前尚未开启可配置功能，所以暂时还是硬编码，补全了所有可能的key
Signed-off-by: taenzeyang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改动说明
在NFD执行对不含namespace的标签打上默认前缀时，跳过华为相关的标签
添加了自动对带有华为设备的节点打上相关标签的nodefeaturerules，此功能可以在values.yaml里关闭