Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched id/name for CBuildConfigProvider #1081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonahgraham
Copy link
Member

This seems to only cause issues when using the plugin.xml GUI editor because it cannot find the exsd file due to the incorrect id.

This seems to only cause issues when using the plugin.xml GUI editor
because it cannot find the exsd file due to the incorrect id.
@jonahgraham
Copy link
Member Author

@betamaxbandit I think this plus eclipse-pde/eclipse.pde#1608 and eclipse-pde/eclipse.pde#1611 address the issues you raised today about the plugin.xml editor not working well.

Copy link

Test Results

   600 files  ±0     600 suites  ±0   13m 26s ⏱️ ±0s
10 207 tests ±0  10 184 ✅ ±0  23 💤 ±0  0 ❌ ±0 
10 245 runs  ±0  10 222 ✅ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 66d0345. ± Comparison against base commit f0c74ed.

@betamaxbandit
Copy link
Contributor

@jonahgraham , cool. Thanks.
I look forward to getting the fix.

In my oomph installed "Eclipse IDE for Eclipse Committers (includes Incubating components) Version: 2024-12 (4.34.0) Build id: 20241128-0757" if I do "Check for updates", will I get the #1609 change?

@jonahgraham
Copy link
Member Author

No, you won't get my fix in PDE until you update to latest I-build for 4.35, or wait until 2025-03 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants