Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2343 - EclipseLink disallows @Version attribute of type java.time.LocalDateTime #2347

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

Tomas-Kraus
Copy link
Member

Implemented missing policies for java.time.LocalDateTime and java.time.Instant.

Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except enum recomendation and if tests will pass)

/** Time from the server. */
public static final int SERVER_TIME = 1;
/** Local time. */
public static final int LOCAL_TIME = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor into enum?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had enum in my 1st fix version. But I remember my long discussion with Lukas related to this topic. :) That's why I keep original solution here.

@Tomas-Kraus Tomas-Kraus self-assigned this Jan 22, 2025
@Tomas-Kraus Tomas-Kraus merged commit 3aee10d into eclipse-ee4j:master Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EclipseLink disallows @Version attribute of type java.time.LocalDateTime
2 participants