Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using CORBA+ORB+PFL to be compatible with JDK11 - 23 #25364

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Feb 4, 2025

Basic problem

  • Usage of Unsafe methods which don't exist in later Java versions.
  • With the absence of JPMS behavior of proxies changes with every Java version
  • JPMS enforces clean API without overlapping packages, so I had to fix some issues in dependencies.

Prerequisities

Notes

@dmatej dmatej added the component upgrade A component dependency has been upgraded label Feb 4, 2025
@dmatej dmatej added this to the 7.0.23 milestone Feb 4, 2025
@dmatej dmatej force-pushed the corba-horror-2025 branch from d04db3b to 85ec466 Compare February 8, 2025 22:01
@dmatej dmatej requested a review from pzygielo February 9, 2025 20:50
@dmatej
Copy link
Contributor Author

dmatej commented Feb 9, 2025

Status:

  • All GlassFish tests passed locally
  • All TCK tests passed locally

TODO:

@pzygielo As you are the only person reacting and having rights, could you please help me with reviews, merges and releases of those dependencies?

@dmatej dmatej force-pushed the corba-horror-2025 branch 2 times, most recently from 15a1dcf to 4ccb59f Compare February 20, 2025 11:51
@dmatej dmatej marked this pull request as ready for review February 20, 2025 11:51
@dmatej dmatej requested a review from a team February 20, 2025 11:51
@dmatej
Copy link
Contributor Author

dmatej commented Feb 20, 2025

Status:

  • All dependencies staged, but not pushed to Maven Central yet, because they need the release review
  • This PR was updated, so I switched that from Draft.
  • IF we would need to restage artifacts, don't forget to purge all maven caches to get rebuilt artifacts! Also please in such situation add a comment about it here.

@dmatej dmatej marked this pull request as draft February 20, 2025 23:46
@dmatej
Copy link
Contributor Author

dmatej commented Feb 20, 2025

Converting to draft again. GlassFish detected a new error in ORB, I have reproduced it, but I am not sure which changed caused that. I will provide more info in few days, I hope a fix too.

@dmatej
Copy link
Contributor Author

dmatej commented Feb 25, 2025

We are back on track!
TODO:

  • Pass the release review of staged artifacts
  • Release to Maven Central
  • Merge this

@dmatej dmatej self-assigned this Mar 20, 2025
@dmatej dmatej modified the milestones: 7.0.23, 7.0.24 Mar 20, 2025
Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej force-pushed the corba-horror-2025 branch from 4ccb59f to 75cc429 Compare March 20, 2025 21:20
@dmatej dmatej requested a review from arjantijms March 20, 2025 21:20
@dmatej dmatej merged commit b104dd5 into eclipse-ee4j:master Mar 21, 2025
4 checks passed
@dmatej dmatej deleted the corba-horror-2025 branch March 21, 2025 09:45
@dmatej
Copy link
Contributor Author

dmatej commented Mar 21, 2025

Note: I merged that, but for sure I will run the whole TCK set locally to see if any of changes made after the last execution did not break anything. If it would, we will patch it asap and create another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component upgrade A component dependency has been upgraded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants