Build the python poc #239
Open
Build the python poc #239
+82
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-editable mode.
Command for build:
* editable:
```
conan install conanfile.py cloe/0.22.0-develop@cloe/develop --install-folder="build" --build=outdated && \
cmake --preset=debug && \
cmake --build --preset=debug
```
* non-editable:
`conan create . cloe/develop`
cassava
requested changes
Apr 29, 2024
cassava
requested changes
May 14, 2024
| from ._cloe_bindings import CallbackResult | ||
| from _cloe_bindings import CallbackResult |
There was a problem hiding this comment.
Above you're still importing from ._runner, implying that mechanism still works.
So what is removing relative import gaining here?
There was a problem hiding this comment.
In editable mode the _cloe_bindings.so file is not next to the python file so relative import won't work.
Python finds it through the PYTHONPATH env variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the developer to build the conan project in editable and non-editable mode.