Merge pull request jenkins-x#108 from abayer/add-name-to-bbc-status

chore: Add name field to BitBucket Cloud commit status creation
eddycharly · Apr 27, 2020 · af36b23 · af36b23
2 parents 2a89b51 + 7bc8e5a
commit af36b23
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/scm/driver/bitbucket/repo.go b/scm/driver/bitbucket/repo.go
@@ -176,6 +176,7 @@ func (s *repositoryService) CreateStatus(ctx context.Context, repo, ref string,
 		State: convertFromState(input.State),
 		Desc:  input.Desc,
 		Key:   input.Label,
+		Name:  input.Label,
 		URL:   input.Target,
 	}
 	out := new(status)

diff --git a/scm/driver/bitbucket/repo_test.go b/scm/driver/bitbucket/repo_test.go
@@ -172,6 +172,7 @@ func TestStatusCreate(t *testing.T) {
 
 	gock.New("https://api.bitbucket.org").
 		Post("/2.0/repositories/atlassian/stash-example-plugin/commit/a6e5e7d797edf751cbd839d6bd4aef86c941eec9/statuses/build").
+		File("testdata/status_input.json").
 		Reply(201).
 		Type("application/json").
 		File("testdata/status.json")

diff --git a/scm/driver/bitbucket/testdata/status_input.json b/scm/driver/bitbucket/testdata/status_input.json
@@ -0,0 +1,7 @@
+{
+  "state": "SUCCESSFUL",
+  "name": "continuous-integration/drone",
+  "key": "continuous-integration/drone",
+  "description": "Build has completed successfully",
+  "url": "https://ci.example.com/1000/output"
+}