Unify --instance arg for extension commands #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension commands used to have an "instance" paramater that used same keys (--instance, -I) as the global instance connection parameter. This PR unifies these two. The practical effect is that `-I`/`--instance` can be specified anywhere between commands instead of just at the end, as it used to have to be. We might also want to infer the instance from the current project.
msullivan
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension commands used to have an "instance" paramater
that used same keys (--instance, -I) as the global instance connection
parameter. This PR unifies these two.
The practical effect is that
-I/--instancecan be specified anywherebetween commands instead of just at the end, as it used to have to be.
We might also want to infer the instance from the current project.