Skip to content

Commit

Permalink
Unbreak devcontainer (langchain-ai#8154)
Browse files Browse the repository at this point in the history
Codespaces and devcontainer was broken by the [repo
restructure](langchain-ai#8043).



- Description: Add libs/langchain to container so it can be built
without error.
  - Issue: -
  - Dependencies: -
  - Tag maintainer: @hwchase17 @baskaryan 
  - Twitter handle: @finnless

The failed build log says:
```
langchain-ai#10 [langchain-dev-dependencies 2/2] RUN poetry install --no-interaction --no-ansi --with dev,test,docs
langchain-ai#10 sha256:e850ee99fc966158bfd2d85e82b7c57244f47ecbb1462e75bd83b981a56a1929
2023-07-23 23:30:33.692Z: langchain-ai#10 0.827 
langchain-ai#10 0.827 Directory libs/langchain does not exist
2023-07-23 23:30:33.738Z: langchain-ai#10 ERROR: executor failed running [/bin/sh -c poetry install --no-interaction --no-ansi --with dev,test,docs]: exit code: 1
```

The new pyproject.toml imports from libs/langchain:

https://github.com/langchain-ai/langchain/blob/77bf75c236351edf47d3a76a522bb45ccc90d299/pyproject.toml#L14-L16

But libs/langchain is never added to the dev.Dockerfile:


https://github.com/langchain-ai/langchain/blob/77bf75c236351edf47d3a76a522bb45ccc90d299/libs/langchain/dev.Dockerfile#L37-L39
  • Loading branch information
finnless authored Jul 24, 2023
1 parent fb62f2b commit 7686dab
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions libs/langchain/dev.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,8 @@ ARG PYTHON_VIRTUALENV_HOME
# Copy only the dependency files for installation
COPY pyproject.toml poetry.toml ./

# Copy the langchain library for installation
COPY libs/langchain/ libs/langchain/

# Install the Poetry dependencies (this layer will be cached as long as the dependencies don't change)
RUN poetry install --no-interaction --no-ansi --with dev,test,docs
5 changes: 5 additions & 0 deletions poetry.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[virtualenvs]
in-project = true

[installer]
modern-installation = false

0 comments on commit 7686dab

Please sign in to comment.