little code improvements and performance improvements

edigu · Dec 2, 2014 · f6fd83c · f6fd83c
1 parent 5b557b2
commit f6fd83c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/library/Zend/Form/View/Helper/File/FormFileUploadProgress.php b/library/Zend/Form/View/Helper/File/FormFileUploadProgress.php
@@ -38,11 +38,12 @@ public function __invoke(ElementInterface $element = null)
      */
     public function renderHiddenId()
     {
-        $attributes          = array();
-        $attributes['id']    = 'progress_key';
-        $attributes['name']  = $this->getName();
-        $attributes['type']  = 'hidden';
-        $attributes['value'] = $this->getValue();
+        $attributes = array(
+            'id'    => 'progress_key',
+            'name'  => $this->getName(),
+            'type'  => 'hidden',
+            'value' => $this->getValue()
+        );
 
         return sprintf(
             '<input %s%s',

diff --git a/library/Zend/Form/View/Helper/Form.php b/library/Zend/Form/View/Helper/Form.php
@@ -94,9 +94,7 @@ public function openTag(FormInterface $form = null)
             $attributes = array_merge($attributes, $formAttributes);
         }
 
-        $tag = sprintf('<form %s>', $this->createAttributesString($attributes));
-
-        return $tag;
+        return sprintf('<form %s>', $this->createAttributesString($attributes));
     }
 
     /**

diff --git a/library/Zend/Form/View/Helper/FormDateTimeSelect.php b/library/Zend/Form/View/Helper/FormDateTimeSelect.php
@@ -144,9 +144,8 @@ public function render(ElementInterface $element)
                 $markup .= $data[$value];
             }
         }
-        $markup = trim($markup);
 
-        return $markup;
+        return trim($markup);
     }
 
     /**

diff --git a/library/Zend/Uri/UriFactory.php b/library/Zend/Uri/UriFactory.php
@@ -73,9 +73,9 @@ public static function getRegisteredSchemeClass($scheme)
     {
         if (isset(static::$schemeClasses[$scheme])) {
             return static::$schemeClasses[$scheme];
-        } else {
-            return null;
         }
+
+        return null;
     }
 
     /**