Skip to content

Commit

Permalink
all: bundle with esbuild instead of webpack
Browse files Browse the repository at this point in the history
Bundling with esbuild is considerably faster than with webpack: on my
PC, webpack takes ~8.5 seconds and esbuild takes ~50 milliseconds.

Fixes golang#1705

Change-Id: If3df213195fb56f652a09135ef5f8b438060f16a
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/343791
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Trust: Hyang-Ah Hana Kim <[email protected]>
Trust: Suzy Mueller <[email protected]>
  • Loading branch information
firelizzard18 authored and hyangah committed Aug 20, 2021
1 parent 83aa2cb commit 3f434bd
Show file tree
Hide file tree
Showing 7 changed files with 63 additions and 1,631 deletions.
3 changes: 3 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"recommendations": ["connor4312.esbuild-problem-matchers"]
}
4 changes: 2 additions & 2 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"stopOnEntry": false,
"sourceMaps": true,
"smartStep": true,
"preLaunchTask": "npm: webpack",
"preLaunchTask": "npm: bundle-dev",
"env": {
"VSCODE_GO_IN_TEST": "" // Enable code
},
Expand All @@ -44,7 +44,7 @@
],
"sourceMaps": true,
"smartStep": true,
"preLaunchTask": "npm: webpack"
"preLaunchTask": "npm: bundle-dev"
},
{
"name": "Launch Extension Tests",
Expand Down
16 changes: 16 additions & 0 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,22 @@
"kind": "build",
"isDefault": true
}
},
{
"type": "npm",
"script": "bundle-watch",
"group": "build",
"problemMatcher": "$esbuild-watch",
"isBackground": true,
"presentation": {
"reveal": "never"
}
},
{
"type": "npm",
"script": "bundle-dev",
"group": "build",
"problemMatcher": "$esbuild",
}
]
}
1 change: 0 additions & 1 deletion .vscodeignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,3 @@ third_party/
tools/
tsconfig.json
typings/
webpack.config.js
Loading

0 comments on commit 3f434bd

Please sign in to comment.