Add /system/indices/index_sets/{id}/stats to fetch individual index s…

…et stats (Graylog2#4129) Closes Graylog2#4088
edmundoa · Sep 11, 2017 · bd65376 · bd65376
1 parent 73e87d1
commit bd65376
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 0 deletions.
diff --git a/...g2-server/src/main/java/org/graylog2/rest/resources/system/indexer/IndexSetsResource.java b/...g2-server/src/main/java/org/graylog2/rest/resources/system/indexer/IndexSetsResource.java
@@ -170,6 +170,22 @@ public IndexSetSummary get(@ApiParam(name = "id", required = true)
                 .orElseThrow(() -> new NotFoundException("Couldn't load index set with ID <" + id + ">"));
     }
 
+    @GET
+    @Path("{id}/stats")
+    @Timed
+    @ApiOperation(value = "Get index set statistics")
+    @ApiResponses(value = {
+            @ApiResponse(code = 403, message = "Unauthorized"),
+            @ApiResponse(code = 404, message = "Index set not found"),
+    })
+    public IndexSetStats indexSetStatistics(@ApiParam(name = "id", required = true)
+                                            @PathParam("id") String id) {
+        checkPermission(RestPermissions.INDEXSETS_READ, id);
+        return indexSetRegistry.get(id)
+                .map(indexSetStatsCreator::getForIndexSet)
+                .orElseThrow(() -> new NotFoundException("Couldn't load index set with ID <" + id + ">"));
+    }
+
     @POST
     @Timed
     @ApiOperation(value = "Create index set")

diff --git a/...erver/src/test/java/org/graylog2/rest/resources/system/indexer/IndexSetsResourceTest.java b/...erver/src/test/java/org/graylog2/rest/resources/system/indexer/IndexSetsResourceTest.java
@@ -32,6 +32,7 @@
 import org.graylog2.plugin.cluster.ClusterConfigService;
 import org.graylog2.rest.resources.system.indexer.requests.IndexSetUpdateRequest;
 import org.graylog2.rest.resources.system.indexer.responses.IndexSetResponse;
+import org.graylog2.rest.resources.system.indexer.responses.IndexSetStats;
 import org.graylog2.rest.resources.system.indexer.responses.IndexSetSummary;
 import org.graylog2.shared.bindings.GuiceInjectorHolder;
 import org.graylog2.system.jobs.SystemJobManager;
@@ -245,6 +246,46 @@ public void getDenied() {
         }
     }
 
+    @Test
+    public void indexSetStatistics() {
+        final IndexSet indexSet = mock(IndexSet.class);
+        final IndexSetStats indexSetStats = IndexSetStats.create(5L, 23L, 42L);
+
+        when(indexSetRegistry.get("id")).thenReturn(Optional.of(indexSet));
+        when(indexSetStatsCreator.getForIndexSet(indexSet)).thenReturn(indexSetStats);
+
+        assertThat(indexSetsResource.indexSetStatistics("id")).isEqualTo(indexSetStats);
+    }
+
+    @Test
+    public void indexSetStatistics0() {
+        when(indexSetRegistry.get("id")).thenReturn(Optional.empty());
+
+        expectedException.expect(NotFoundException.class);
+        expectedException.expectMessage("Couldn't load index set with ID <id>");
+
+        try {
+            indexSetsResource.indexSetStatistics("id");
+        } finally {
+            verify(indexSetRegistry, times(1)).get("id");
+            verifyNoMoreInteractions(indexSetRegistry);
+        }
+    }
+
+    @Test
+    public void indexSetStatisticsDenied() {
+        notPermitted();
+
+        expectedException.expect(ForbiddenException.class);
+        expectedException.expectMessage("Not authorized to access resource id <id>");
+
+        try {
+            indexSetsResource.indexSetStatistics("id");
+        } finally {
+            verifyZeroInteractions(indexSetRegistry);
+        }
+    }
+
     @Test
     public void save() {
         final IndexSetConfig indexSetConfig = IndexSetConfig.create(