Skip to content

Commit

Permalink
Update CODEOWNERS for updates to genesis and network config snapshots (
Browse files Browse the repository at this point in the history
…MystenLabs#3863)

* add CODEOWNERS to snapshot_tests.rs

* Add comment for what to do when breaking genesis snapshot

* Fix owners for crypto files
  • Loading branch information
mwtian authored Aug 9, 2022
1 parent 4863e57 commit c8dd20e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
sui_core/src/crypto.rs @huitseeker
sui/src/keystore.rs @huitseeker @patrickkuo
/crates/sui-types/src/crypto.rs @huitseeker
/crates/sui-sdk/src/crypto.rs @huitseeker @patrickkuo

*.md @Clay-Mysten @randall-Mysten

# When snapshot changes, most likely we will need to recreate the genesis blob.
/crates/sui-config/tests/snapshot_tests.rs @tharbert @huitseeker
4 changes: 4 additions & 0 deletions crates/sui-config/tests/snapshot_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ fn genesis_config_snapshot_matches() {
assert_yaml_snapshot!(genesis_config);
}

// If a Move change breaks the test below, it is because related Move functions are included
// in the genesis blob. The test failure can be fixed by updating the snapshot / blob.
// Also, folks in the file's CODEWOWNERS should be notified about the change. They may need to
// re-create the genesis blob.
#[test]
fn empty_genesis_snapshot_matches() {
let genesis = Builder::new().build();
Expand Down

0 comments on commit c8dd20e

Please sign in to comment.