Simplify actoolzip argument flow

-- MOS_MIGRATED_REVID=88789823
eduaranega · Mar 18, 2015 · db16149 · db16149
1 parent 7ad1e0e
commit db16149
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/BundleSupport.java b/src/main/java/com/google/devtools/build/lib/rules/objc/BundleSupport.java
@@ -15,7 +15,6 @@
 package com.google.devtools.build.lib.rules.objc;
 
 import com.google.common.base.Optional;
-import com.google.common.collect.ImmutableList;
 import com.google.devtools.build.lib.actions.Artifact;
 import com.google.devtools.build.lib.analysis.RuleConfiguredTarget.Mode;
 import com.google.devtools.build.lib.analysis.RuleContext;
@@ -134,12 +133,8 @@ private void registerActoolActionIfNecessary(ObjcProvider objcProvider) {
         new ObjcRuleClasses.Tools(ruleContext),
         objcProvider,
         actoolzipOutput.get(),
-        new ObjcActionsBuilder.ExtraActoolOutputs(actoolPartialInfoplist),
-        new ExtraActoolArgs(
-            new ImmutableList.Builder<String>()
-                .addAll(extraActoolArgs)
-                .add("--output-partial-info-plist", actoolPartialInfoplist.getExecPathString())
-                .build()),
+        actoolPartialInfoplist,
+        extraActoolArgs,
         targetDeviceFamilies);
   }
 

diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcActionsBuilder.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcActionsBuilder.java
@@ -355,7 +355,7 @@ void registerActoolzipAction(
       ObjcRuleClasses.Tools tools,
       ObjcProvider provider,
       Artifact zipOutput,
-      ExtraActoolOutputs extraActoolOutputs,
+      Artifact partialInfoPlist,
       ExtraActoolArgs extraActoolArgs,
       Set<TargetDeviceFamily> families) {
     // TODO(bazel-team): Do not use the deploy jar explicitly here. There is currently a bug where
@@ -367,11 +367,12 @@ void registerActoolzipAction(
         .setMnemonic("AssetCatalogCompile")
         .addTransitiveInputs(provider.get(ASSET_CATALOG))
         .addOutput(zipOutput)
-        .addOutputs(extraActoolOutputs)
+        .addOutput(partialInfoPlist)
         .setCommandLine(actoolzipCommandLine(
             objcConfiguration,
             provider,
             zipOutput,
+            partialInfoPlist,
             extraActoolArgs,
             ImmutableSet.copyOf(families)))
         .build(context));
@@ -381,6 +382,7 @@ private static CommandLine actoolzipCommandLine(
       final ObjcConfiguration objcConfiguration,
       final ObjcProvider provider,
       final Artifact zipOutput,
+      final Artifact partialInfoPlist,
       final ExtraActoolArgs extraActoolArgs,
       final ImmutableSet<TargetDeviceFamily> families) {
     return new CommandLine() {
@@ -393,6 +395,7 @@ public Iterable<String> arguments() {
             .add(IosSdkCommands.ACTOOL_PATH)
             .add("--platform")
             .add(objcConfiguration.getPlatform().getLowerCaseNameInPlist())
+            .add("--output-partial-info-plist").add(partialInfoPlist.getExecPathString())
             .add("--minimum-deployment-target").add(objcConfiguration.getMinimumOs());
         for (TargetDeviceFamily targetDeviceFamily : families) {
           args.add("--target-device").add(targetDeviceFamily.name().toLowerCase(Locale.US));