Fix ClassNotFound handling (corda#5078)

edward-prosser · May 2, 2019 · 25f3358 · 25f3358
1 parent 268f6db
commit 25f3358
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/core/src/main/kotlin/net/corda/core/transactions/TransactionBuilder.kt b/core/src/main/kotlin/net/corda/core/transactions/TransactionBuilder.kt
@@ -27,6 +27,7 @@ import java.util.regex.Pattern
 import kotlin.collections.ArrayList
 import kotlin.collections.component1
 import kotlin.collections.component2
+import kotlin.reflect.KClass
 
 /**
  * A TransactionBuilder is a transaction class that's mutable (unlike the others which are all immutable). It is
@@ -169,6 +170,13 @@ open class TransactionBuilder(
             wireTx
     }
 
+    // Returns the first exception in the hierarchy that matches one of the [types].
+    private tailrec fun Throwable.rootClassNotFoundCause(vararg types: KClass<*>): Throwable = when {
+        this::class in types -> this
+        this.cause == null -> this
+        else -> this.cause!!.rootClassNotFoundCause(*types)
+    }
+
     /**
      * @return true if a new dependency was successfully added.
      */
@@ -178,7 +186,8 @@ open class TransactionBuilder(
             // The transaction verified successfully without adding any extra dependency.
             false
         } catch (e: Throwable) {
-            val rootError = e.rootCause
+            val rootError = e.rootClassNotFoundCause(ClassNotFoundException::class, NoClassDefFoundError::class)
+
             when {
                 // Handle various exceptions that can be thrown during verification and drill down the wrappings.
                 // Note: this is a best effort to preserve backwards compatibility.

diff --git a/serialization/src/main/kotlin/net/corda/serialization/internal/amqp/AMQPExceptions.kt b/serialization/src/main/kotlin/net/corda/serialization/internal/amqp/AMQPExceptions.kt
@@ -23,10 +23,12 @@ internal inline fun <T> ifThrowsAppend(strToAppendFn: () -> String, block: () ->
     try {
         return block()
     } catch (th: Throwable) {
-        if (th is AMQPNotSerializableException) {
-            th.classHierarchy.add(strToAppendFn())
-        } else {
-            th.setMessage("${strToAppendFn()} -> ${th.message}")
+        when (th) {
+            is AMQPNotSerializableException -> th.classHierarchy.add(strToAppendFn())
+            // Do not overwrite the message of these exceptions as it may be used.
+            is ClassNotFoundException -> {}
+            is NoClassDefFoundError -> {}
+            else -> th.setMessage("${strToAppendFn()} -> ${th.message}")
         }
         throw th
     }