-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add enterprise-catalog in devstack #81
chore: add enterprise-catalog in devstack #81
Conversation
5d90f7a
to
7678187
Compare
54705a2
to
343b4cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more changes, also you need to rebase it correctly with main
branch as it is currently also including the changes from master.
343b4cd
to
9105836
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change, rest 👍
Makefile
Outdated
dev.shell.enterprise-catalog: | ||
docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change as this will be handled by dev.shell.%
target.
Makefile
Outdated
dev.shell.enterprise-catalog: | ||
docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev.shell.enterprise-catalog: | |
docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash' |
suggestion for commit
0a17398
to
09c7fde
Compare
No description provided.