Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add enterprise-catalog in devstack #81

Merged

Conversation

huniafatima-arbi
Copy link
Member

No description provided.

@huniafatima-arbi huniafatima-arbi self-assigned this Nov 19, 2024
@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/add-enterprise-catalog-in-devstack branch from 5d90f7a to 7678187 Compare November 20, 2024 09:21
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
provision.sh Outdated Show resolved Hide resolved
provision-enterprise_catalog.sh Outdated Show resolved Hide resolved
provision-enterprise_catalog.sh Outdated Show resolved Hide resolved
@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/add-enterprise-catalog-in-devstack branch from 54705a2 to 343b4cd Compare November 22, 2024 19:04
Copy link
Member

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes, also you need to rebase it correctly with main branch as it is currently also including the changes from master.

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
provision-enterprise_catalog.sh Outdated Show resolved Hide resolved
provision-enterprise_catalog.sh Outdated Show resolved Hide resolved
provision-enterprise_catalog.sh Outdated Show resolved Hide resolved
@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/add-enterprise-catalog-in-devstack branch from 343b4cd to 9105836 Compare November 28, 2024 08:21
@iamsobanjaved iamsobanjaved linked an issue Jan 1, 2025 that may be closed by this pull request
Copy link
Member

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change, rest 👍

Makefile Outdated
Comment on lines 410 to 412
dev.shell.enterprise-catalog:
docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change as this will be handled by dev.shell.% target.

Makefile Outdated
Comment on lines 410 to 412
dev.shell.enterprise-catalog:
docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dev.shell.enterprise-catalog:
docker exec -it edx.devstack.enterprise-catalog env TERM=$(TERM) bash -c '/bin/bash'

suggestion for commit

@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/add-enterprise-catalog-in-devstack branch from 0a17398 to 09c7fde Compare January 1, 2025 09:56
@huniafatima-arbi huniafatima-arbi merged commit 6d5392b into master Jan 3, 2025
12 checks passed
@huniafatima-arbi huniafatima-arbi deleted the huniafatima/add-enterprise-catalog-in-devstack branch January 3, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add openedx/enterprise-catalog to devstack
3 participants