Comment has been added to fix (issue protocolbuffers#1266)

eeight · Mar 8, 2016 · e2fb1d9 · e2fb1d9
1 parent 3cc35ad
commit e2fb1d9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/google/protobuf/map.h b/src/google/protobuf/map.h
@@ -548,6 +548,10 @@ class Map {
     !defined(GOOGLE_PROTOBUF_OS_NACL) && !defined(GOOGLE_PROTOBUF_OS_ANDROID)
     template<class NodeType, class... Args>
     void construct(NodeType* p, Args&&... args) {
+      // Clang 3.6 doesn't compile static casting to void* directly. (Issue #1266)
+      // According C++ standard 5.2.9/1: "The static_cast operator shall not cast
+      // away constness". So first the maybe const pointer is casted to const void* and
+      // after the const void* is const casted.
       new (const_cast<void*>(static_cast<const void*>(p))) NodeType(std::forward<Args>(args)...);
     }