Skip to content

Commit

Permalink
Use upstream Qhull, remove duplication in deps and src
Browse files Browse the repository at this point in the history
REALfloat is not defined to 0 on all platforms.
  • Loading branch information
tamasmeszaros committed Apr 4, 2022
1 parent 057232a commit 1070d71
Show file tree
Hide file tree
Showing 238 changed files with 13 additions and 104,166 deletions.
9 changes: 3 additions & 6 deletions deps/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -195,19 +195,16 @@ set(_dep_list
dep_OpenVDB
dep_OpenCSG
dep_CGAL
dep_Qhull
${PNG_PKG}
${ZLIB_PKG}
${EXPAT_PKG}
)

if (MSVC)
# Experimental
#list(APPEND _dep_list "dep_qhull")
else()
list(APPEND _dep_list "dep_Qhull")
# if (NOT MSVC)
# Not working, static build has different Eigen
#list(APPEND _dep_list "dep_libigl")
endif()
# endif()

add_custom_target(deps ALL DEPENDS ${_dep_list})

Expand Down
11 changes: 10 additions & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ add_subdirectory(boost)
add_subdirectory(clipper)
add_subdirectory(miniz)
add_subdirectory(glu-libtess)
add_subdirectory(qhull)
add_subdirectory(Shiny)
add_subdirectory(semver)
add_subdirectory(libigl)
Expand All @@ -19,6 +18,16 @@ add_subdirectory(qoi)
# Adding libnest2d project for bin packing...
add_subdirectory(libnest2d)

find_package(Qhull 7.2 REQUIRED)
add_library(qhull INTERFACE)
if(SLIC3R_STATIC)
slic3r_remap_configs("Qhull::qhullcpp;Qhull::qhullstatic_r" RelWithDebInfo Release)
target_link_libraries(qhull INTERFACE Qhull::qhullcpp Qhull::qhullstatic_r)
else()
slic3r_remap_configs("Qhull::qhullcpp;Qhull::qhull_r" RelWithDebInfo Release)
target_link_libraries(qhull INTERFACE Qhull::qhullcpp Qhull::qhull_r)
endif()

add_subdirectory(libslic3r)

if (SLIC3R_GUI)
Expand Down
47 changes: 0 additions & 47 deletions src/qhull/Announce.txt

This file was deleted.

147 changes: 0 additions & 147 deletions src/qhull/CMakeLists.txt

This file was deleted.

38 changes: 0 additions & 38 deletions src/qhull/COPYING.txt

This file was deleted.

Loading

0 comments on commit 1070d71

Please sign in to comment.